Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37657 )
Change subject: Documentation: Fix EC type for facebook and portwell boards ......................................................................
Documentation: Fix EC type for facebook and portwell boards
Board description contained incorrect EC type.
Change EC type to ITE8528
BUG=N/A TEST=build
Change-Id: Ib5af79fb00bfdfc5dbe001b60010a74bddc696e2 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M Documentation/mainboard/facebook/fbg1701.md M Documentation/mainboard/facebook/monolith.md M Documentation/mainboard/portwell/pq7-m107.md 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/37657/1
diff --git a/Documentation/mainboard/facebook/fbg1701.md b/Documentation/mainboard/facebook/fbg1701.md index 06bf42f..e711ef3 100644 --- a/Documentation/mainboard/facebook/fbg1701.md +++ b/Documentation/mainboard/facebook/fbg1701.md @@ -72,7 +72,7 @@ +------------------+--------------------------------------------------+ | CPU | Intel Braswell (N3710) | +------------------+--------------------------------------------------+ -| Super I/O, EC | ITE8256 | +| Super I/O, EC | ITE8528 | +------------------+--------------------------------------------------+ | Coprocessor | Intel Management Engine | +------------------+--------------------------------------------------+ diff --git a/Documentation/mainboard/facebook/monolith.md b/Documentation/mainboard/facebook/monolith.md index 9b9f33b..be7f9617 100644 --- a/Documentation/mainboard/facebook/monolith.md +++ b/Documentation/mainboard/facebook/monolith.md @@ -67,7 +67,7 @@ +------------------+--------------------------------------------------+ | CPU | Intel i3-7100U | +------------------+--------------------------------------------------+ -| Super I/O, EC | ITE8256 | +| Super I/O, EC | ITE8528 | +------------------+--------------------------------------------------+ | Coprocessor | Intel Management Engine | +------------------+--------------------------------------------------+ diff --git a/Documentation/mainboard/portwell/pq7-m107.md b/Documentation/mainboard/portwell/pq7-m107.md index f7e5142..0350ac3 100644 --- a/Documentation/mainboard/portwell/pq7-m107.md +++ b/Documentation/mainboard/portwell/pq7-m107.md @@ -67,7 +67,7 @@ +------------------+--------------------------------------------------+ | CPU | Intel Braswell (N3710) | +------------------+--------------------------------------------------+ -| Super I/O, EC | ITE8256 | +| Super I/O, EC | ITE8528 | +------------------+--------------------------------------------------+ | Coprocessor | Intel Management Engine | +------------------+--------------------------------------------------+
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37657 )
Change subject: Documentation: Fix EC type for facebook and portwell boards ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37657 )
Change subject: Documentation: Fix EC type for facebook and portwell boards ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37657 )
Change subject: Documentation: Fix EC type for facebook and portwell boards ......................................................................
Documentation: Fix EC type for facebook and portwell boards
Board description contained incorrect EC type.
Change EC type to ITE8528
BUG=N/A TEST=build
Change-Id: Ib5af79fb00bfdfc5dbe001b60010a74bddc696e2 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37657 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- M Documentation/mainboard/facebook/fbg1701.md M Documentation/mainboard/facebook/monolith.md M Documentation/mainboard/portwell/pq7-m107.md 3 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/Documentation/mainboard/facebook/fbg1701.md b/Documentation/mainboard/facebook/fbg1701.md index 06bf42f..e711ef3 100644 --- a/Documentation/mainboard/facebook/fbg1701.md +++ b/Documentation/mainboard/facebook/fbg1701.md @@ -72,7 +72,7 @@ +------------------+--------------------------------------------------+ | CPU | Intel Braswell (N3710) | +------------------+--------------------------------------------------+ -| Super I/O, EC | ITE8256 | +| Super I/O, EC | ITE8528 | +------------------+--------------------------------------------------+ | Coprocessor | Intel Management Engine | +------------------+--------------------------------------------------+ diff --git a/Documentation/mainboard/facebook/monolith.md b/Documentation/mainboard/facebook/monolith.md index a469a84..0bc1448 100644 --- a/Documentation/mainboard/facebook/monolith.md +++ b/Documentation/mainboard/facebook/monolith.md @@ -67,7 +67,7 @@ +------------------+--------------------------------------------------+ | CPU | Intel i3-7100U | +------------------+--------------------------------------------------+ -| Super I/O, EC | ITE8256 | +| Super I/O, EC | ITE8528 | +------------------+--------------------------------------------------+ | Coprocessor | Intel Management Engine | +------------------+--------------------------------------------------+ diff --git a/Documentation/mainboard/portwell/pq7-m107.md b/Documentation/mainboard/portwell/pq7-m107.md index f7e5142..0350ac3 100644 --- a/Documentation/mainboard/portwell/pq7-m107.md +++ b/Documentation/mainboard/portwell/pq7-m107.md @@ -67,7 +67,7 @@ +------------------+--------------------------------------------------+ | CPU | Intel Braswell (N3710) | +------------------+--------------------------------------------------+ -| Super I/O, EC | ITE8256 | +| Super I/O, EC | ITE8528 | +------------------+--------------------------------------------------+ | Coprocessor | Intel Management Engine | +------------------+--------------------------------------------------+
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Wim Vervoorn (Code Review)