Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph, EricR Lai.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61331 )
Change subject: intel/common/block/pcie: Add Zero count check in pcie_rp_update_devtree
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/common/block/pcie/pcie_rp.c:
https://review.coreboot.org/c/coreboot/+/61331/comment/af25bcdf_92e33910
PS1, Line 133: if (!group->count)
do you want the NULL check for groups as well?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I132319bb05fdef1590c18302fc64cc76e15bea6d
Gerrit-Change-Number: 61331
Gerrit-PatchSet: 4
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 27 Jan 2022 05:32:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment