Change in coreboot[master]: mainboard/google/fizz: Drop NO_FADT_8042 in Kconfig

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38502 )


Change subject: mainboard/google/fizz: Drop NO_FADT_8042 in Kconfig
......................................................................

mainboard/google/fizz: Drop NO_FADT_8042 in Kconfig

This looks like it is only relevant to Skylake.

Change-Id: Idb82b6339dc6bb78c02d49eddd31623aaad083ad
Signed-off-by: Edward O'Callaghan <[e-mail]>
---
M src/mainboard/google/fizz/Kconfig
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/38502/1

diff --git a/src/mainboard/google/fizz/Kconfig b/src/mainboard/google/fizz/Kconfig
index fbe98be..6265297 100644
--- a/src/mainboard/google/fizz/Kconfig
+++ b/src/mainboard/google/fizz/Kconfig
@@ -18,7 +18,6 @@
 	select INTEL_LPSS_UART_FOR_CONSOLE
 	select MAINBOARD_HAS_CHROMEOS
 	select MAINBOARD_HAS_LIBGFXINIT
-	select NO_FADT_8042
 	select SOC_INTEL_KABYLAKE
 	select MAINBOARD_HAS_SPI_TPM_CR50
 	select MAINBOARD_HAS_TPM2

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/38502
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb82b6339dc6bb78c02d49eddd31623aaad083ad
Gerrit-Change-Number: 38502
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-MessageType: newchange

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38502 )

Change subject: mainboard/google/fizz: Drop NO_FADT_8042 in Kconfig
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38502/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38502/1//COMMIT_MSG@9 
PS1, Line 9: Skylake
Skylake and Kaby lake? Since both use soc/intel/skylake in coreboot?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/38502
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb82b6339dc6bb78c02d49eddd31623aaad083ad
Gerrit-Change-Number: 38502
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Furquan Shaikh <[e-mail]>
Gerrit-Reviewer: Kangheui Won <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Wed, 22 Jan 2020 20:51:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38502 )

Change subject: mainboard/google/fizz: Drop NO_FADT_8042 in Kconfig
......................................................................


Abandoned

ah oh
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/38502
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb82b6339dc6bb78c02d49eddd31623aaad083ad
Gerrit-Change-Number: 38502
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Furquan Shaikh <[e-mail]>
Gerrit-Reviewer: Kangheui Won <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-MessageType: abandon