Attention is currently required from: Tim Wawrzynczak, Arthur Heymans, Eric Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63009 )
Change subject: soc/intel/alderlake: Enable FSP_DEBUG_EVENT_HANDLER_IN_COREBOOT Kconfig ......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/63009/comment/6a06176d_637b82f4 PS2, Line 43: select FSP_DEBUG_EVENT_HANDLER_IN_COREBOOT
Can we depend CONFIG_CONSOLE_SERIAL or CONFIG_UART_DEBUG? I think the normal image, we don't need to know FSP log.
Isn't the whole point to be console agnostic and let coreboot do the console printing wherever it seems fit? Even without series I still see value in printing output to for instance the cbmem console.
Unless u have debug FSP image in repository, you won't see the FSP debug log with normal image. But I understood your point, and that can only happen when we have unified FSP binary which is debug always then, it's all about coreboot, how coreboot decides to control the serial log enable/disable. i'm working on a further change list to keep a reduced debug binary so we don't need to have separate FSP build flag while debugging any issue, rather can use coreboot to enable the FSP debug in verbose mode.