Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
mb/siemens/mc_bdx1: Enable VBOOT
Enable VBOOT in Kconfig and provide a flashmap that includes all the needed sections for VBOOT support.
Change-Id: Iee12a5d1781c869b20bc14a52ecbf23474caa3fd Signed-off-by: Werner Zeh werner.zeh@siemens.com --- M src/mainboard/siemens/mc_bdx1/Kconfig A src/mainboard/siemens/mc_bdx1/mc_bdx1.fmd 2 files changed, 41 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/35594/1
diff --git a/src/mainboard/siemens/mc_bdx1/Kconfig b/src/mainboard/siemens/mc_bdx1/Kconfig index 6feb1cf..35d29c1 100644 --- a/src/mainboard/siemens/mc_bdx1/Kconfig +++ b/src/mainboard/siemens/mc_bdx1/Kconfig @@ -15,6 +15,21 @@ select DRIVERS_I2C_PCA9538 select MAINBOARD_HAS_TPM2 select MAINBOARD_HAS_LPC_TPM + select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY + select BOOT_DEVICE_SUPPORTS_WRITES + +config VBOOT + select VBOOT_MEASURED_BOOT + select VBOOT_VBNV_FLASH + select VBOOT_NO_BOARD_SUPPORT + select GBB_FLAG_DISABLE_LID_SHUTDOWN + select GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC + select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC + select GBB_FLAG_DISABLE_FWMP + +config FMDFILE + string + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/mc_bdx1.fmd"
config MAINBOARD_DIR string @@ -30,7 +45,7 @@
config CBFS_SIZE hex - default 0x00D00000 + default 0x00BF4000
config VIRTUAL_ROM_SIZE hex diff --git a/src/mainboard/siemens/mc_bdx1/mc_bdx1.fmd b/src/mainboard/siemens/mc_bdx1/mc_bdx1.fmd new file mode 100644 index 0000000..b8d5d9c --- /dev/null +++ b/src/mainboard/siemens/mc_bdx1/mc_bdx1.fmd @@ -0,0 +1,25 @@ +FLASH@0xff000000 0x1000000 { + SI_ALL@0x0 0x300000 { + SI_DESC@0x0 0x1000 + SI_ME@0x1000 0x2ff000 + } + SI_BIOS@0x300000 0xd00000 { + RW_MRC_CACHE@0x000000 0x10000 + RW_SHARED@0x10000 0x4000 { + SHARED_DATA@0x0 0x2000 + VBLOCK_DEV@0x2000 0x2000 + } + RW_VPD@0x14000 0x2000 + RW_NVRAM@0x16000 0x2000 + WP_RO@0x18000 0xce8000 { + RO_VPD@0x0 0x4000 + RO_SECTION@0x4000 0xce4000 { + FMAP@0x0 0x800 + RO_FRID@0x800 0x40 + RO_FRID_PAD@0x840 0x7c0 + GBB@0x1000 0xef000 + COREBOOT(CBFS)@0xf0000 0xbf4000 + } + } + } +}
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 1: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/mc_bdx1.fmd:
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 1: FLASH@0xff000000 0x1000000 { : SI_ALL@0x0 0x300000 { : SI_DESC@0x0 0x1000 : SI_ME@0x1000 0x2ff000 : } : SI_BIOS@0x300000 0xd00000 { : RW_MRC_CACHE@0x000000 0x10000 : RW_SHARED@0x10000 0x4000 { : SHARED_DATA@0x0 0x2000 : VBLOCK_DEV@0x2000 0x2000 : } : RW_VPD@0x14000 0x2000 : RW_NVRAM@0x16000 0x2000 : WP_RO@0x18000 0xce8000 { : RO_VPD@0x0 0x4000 : RO_SECTION@0x4000 0xce4000 { : FMAP@0x0 0x800 : RO_FRID@0x800 0x40 : RO_FRID_PAD@0x840 0x7c0 : GBB@0x1000 0xef000 : COREBOOT(CBFS)@0xf0000 0xbf4000 : } : } : } : } There is no need to specify all offsets and sizes: see https://review.coreboot.org/c/coreboot/+/33276 as an example
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/Kconfig:
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 18: select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY : select BOOT_DEVICE_SUPPORTS_WRITES This does not seem very mainboard specific?
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/Kconfig:
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 18: select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY : select BOOT_DEVICE_SUPPORTS_WRITES
This does not seem very mainboard specific?
Well, it is needed for thew VBOOT setup to work properly. I gues it is the best place to add it as VBOOT is not enforced in the tree.
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/mc_bdx1.fmd:
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 1: FLASH@0xff000000 0x1000000 { : SI_ALL@0x0 0x300000 { : SI_DESC@0x0 0x1000 : SI_ME@0x1000 0x2ff000 : } : SI_BIOS@0x300000 0xd00000 { : RW_MRC_CACHE@0x000000 0x10000 : RW_SHARED@0x10000 0x4000 { : SHARED_DATA@0x0 0x2000 : VBLOCK_DEV@0x2000 0x2000 : } : RW_VPD@0x14000 0x2000 : RW_NVRAM@0x16000 0x2000 : WP_RO@0x18000 0xce8000 { : RO_VPD@0x0 0x4000 : RO_SECTION@0x4000 0xce4000 { : FMAP@0x0 0x800 : RO_FRID@0x800 0x40 : RO_FRID_PAD@0x840 0x7c0 : GBB@0x1000 0xef000 : COREBOOT(CBFS)@0xf0000 0xbf4000 : } : } : } : }
There is no need to specify all offsets and sizes: see https://review.coreboot. […]
Wow...that is a nice one. I was not a ware of, will try out. Thanks for the pointer.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/Kconfig:
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 18: select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY : select BOOT_DEVICE_SUPPORTS_WRITES
Well, it is needed for thew VBOOT setup to work properly. […]
I wonder why this is needed here as SOUTHBRIDGE_INTEL_COMMON_SPI selects BOOT_DEVICE_SUPPORTS_WRITES and I don't see BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY used anywhere.
The SOC Kconfig would be a more appropriate place I think.
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 32: default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/mc_bdx1.fmd" You could make this depend on "if VBOOT". This would allow the default fmap to be used in a non VBOOT setup with debugging options like spi flash console which needs a separate fmap.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/Kconfig:
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 18: select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY : select BOOT_DEVICE_SUPPORTS_WRITES
I wonder why this is needed here as SOUTHBRIDGE_INTEL_COMMON_SPI selects BOOT_DEVICE_SUPPORTS_WRITES […]
I don't see it on SoC level for now but I might miss something. These switches are needed to enable VBOOT writing its NV data into the SPI flash. For every board which does not have VBOOT enabled it makes no sense to have this featureset included in the binary (though the linker might drop the functions). If I now drop just BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY in the current config, I get the error: src/lib/boot_device.c:55: undefined reference to `boot_device_rw'
in src/drivers/spi/Makefile.inc you can find the following:
$(1)-$(CONFIG_BOOT_DEVICE_SPI_FLASH_RW_NOMMAP$(2)) += boot_device_rw_nommap.c
So to be able to write NV data in romstage (which is needed for VBOOT as it start in romstage for fsp_broadwell_de) you need the switch CONFIG_BOOT_DEVICE_SPI_FLASH_RW_NOMMAP.
Or do I mix up things here?
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 32: default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/mc_bdx1.fmd"
You could make this depend on "if VBOOT". […]
Sounds nice, will try.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/Kconfig:
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 18: select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY : select BOOT_DEVICE_SUPPORTS_WRITES
I don't see it on SoC level for now but I might miss something. These switches are needed to enable VBOOT writing its NV data into the SPI flash. For every board which does not have VBOOT enabled it makes no sense to have this featureset included in the binary (though the linker might drop the functions).
The linker will drop those functions and other SoC have "select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY if BOOT_DEVICE_SPI_FLASH" in their Kconfig so I'd not worry about it.
If I now drop just BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY in the current config, I get the error: src/lib/boot_device.c:55: undefined reference to `boot_device_rw'
in src/drivers/spi/Makefile.inc you can find the following:
$(1)-$(CONFIG_BOOT_DEVICE_SPI_FLASH_RW_NOMMAP$(2)) += boot_device_rw_nommap.c
Ah thanks, I did not found it at first (I was grepping for the full thing).
So to be able to write NV data in romstage (which is needed for VBOOT as it start in romstage for fsp_broadwell_de) you need the switch CONFIG_BOOT_DEVICE_SPI_FLASH_RW_NOMMAP.
Or do I mix up things here?
Yes sounds correct, my bad.
Hello Mario Scheithauer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35594
to look at the new patch set (#2).
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
mb/siemens/mc_bdx1: Enable VBOOT
Enable VBOOT in Kconfig and provide a flashmap that includes all the needed sections for VBOOT support.
Change-Id: Iee12a5d1781c869b20bc14a52ecbf23474caa3fd Signed-off-by: Werner Zeh werner.zeh@siemens.com --- M src/mainboard/siemens/mc_bdx1/Kconfig A src/mainboard/siemens/mc_bdx1/mc_bdx1.fmd 2 files changed, 42 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/35594/2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35594/2/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/Kconfig:
https://review.coreboot.org/c/coreboot/+/35594/2/src/mainboard/siemens/mc_bd... PS2, Line 48: default 0x00BF4000 if VBOOT This should be unused if a separate FMAP is provided.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/Kconfig:
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 18: select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY : select BOOT_DEVICE_SUPPORTS_WRITES
I don't see it on SoC level for now but I might miss something. […]
Do you insist on moving these switches to SoC? I mean I can do it if you see it as absolutely necessary.
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 32: default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/mc_bdx1.fmd"
Sounds nice, will try.
Ack
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35594/2/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/Kconfig:
https://review.coreboot.org/c/coreboot/+/35594/2/src/mainboard/siemens/mc_bd... PS2, Line 48: default 0x00BF4000 if VBOOT
This should be unused if a separate FMAP is provided.
Yes, I was not so happy about synching these values, too. Will remove.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/Kconfig:
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 18: select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY : select BOOT_DEVICE_SUPPORTS_WRITES
Do you insist on moving these switches to SoC? I mean I can do it if you see it as absolutely necessary.
I do insist. It's consistent with the tree and the advantages of always building it on BROADWELL_DE outweigh the small increase in buildtime.
I tested with BUILD_TIMELESS=1 and without VBOOT (so nothing calling the functions) the resulting binary is the same with or without those options.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/Kconfig:
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 18: select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY : select BOOT_DEVICE_SUPPORTS_WRITES
Do you insist on moving these switches to SoC? I mean I can do it if you see it as absolutely nece […]
OK, thank you for the test. I will move these switches into SoC.
Hello Mario Scheithauer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35594
to look at the new patch set (#3).
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
mb/siemens/mc_bdx1: Enable VBOOT
Enable VBOOT in Kconfig and provide a flashmap that includes all the needed sections for VBOOT support.
Change-Id: Iee12a5d1781c869b20bc14a52ecbf23474caa3fd Signed-off-by: Werner Zeh werner.zeh@siemens.com --- M src/mainboard/siemens/mc_bdx1/Kconfig A src/mainboard/siemens/mc_bdx1/mc_bdx1.fmd 2 files changed, 39 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/35594/3
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 3: Code-Review+2
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35594/2/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/Kconfig:
https://review.coreboot.org/c/coreboot/+/35594/2/src/mainboard/siemens/mc_bd... PS2, Line 48: default 0x00BF4000 if VBOOT
Yes, I was not so happy about synching these values, too. […]
Ack
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/Kconfig:
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 18: select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY : select BOOT_DEVICE_SUPPORTS_WRITES
OK, thank you for the test. I will move these switches into SoC.
Ack
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/mc_bdx1.fmd:
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 1: FLASH@0xff000000 0x1000000 { : SI_ALL@0x0 0x300000 { : SI_DESC@0x0 0x1000 : SI_ME@0x1000 0x2ff000 : } : SI_BIOS@0x300000 0xd00000 { : RW_MRC_CACHE@0x000000 0x10000 : RW_SHARED@0x10000 0x4000 { : SHARED_DATA@0x0 0x2000 : VBLOCK_DEV@0x2000 0x2000 : } : RW_VPD@0x14000 0x2000 : RW_NVRAM@0x16000 0x2000 : WP_RO@0x18000 0xce8000 { : RO_VPD@0x0 0x4000 : RO_SECTION@0x4000 0xce4000 { : FMAP@0x0 0x800 : RO_FRID@0x800 0x40 : RO_FRID_PAD@0x840 0x7c0 : GBB@0x1000 0xef000 : COREBOOT(CBFS)@0xf0000 0xbf4000 : } : } : } : }
Wow...that is a nice one. I was not a ware of, will try out. Thanks for the pointer.
Done
Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
mb/siemens/mc_bdx1: Enable VBOOT
Enable VBOOT in Kconfig and provide a flashmap that includes all the needed sections for VBOOT support.
Change-Id: Iee12a5d1781c869b20bc14a52ecbf23474caa3fd Signed-off-by: Werner Zeh werner.zeh@siemens.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35594 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/siemens/mc_bdx1/Kconfig A src/mainboard/siemens/mc_bdx1/mc_bdx1.fmd 2 files changed, 39 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/mainboard/siemens/mc_bdx1/Kconfig b/src/mainboard/siemens/mc_bdx1/Kconfig index 6feb1cf..0067582 100644 --- a/src/mainboard/siemens/mc_bdx1/Kconfig +++ b/src/mainboard/siemens/mc_bdx1/Kconfig @@ -16,6 +16,19 @@ select MAINBOARD_HAS_TPM2 select MAINBOARD_HAS_LPC_TPM
+config VBOOT + select VBOOT_MEASURED_BOOT + select VBOOT_VBNV_FLASH + select VBOOT_NO_BOARD_SUPPORT + select GBB_FLAG_DISABLE_LID_SHUTDOWN + select GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC + select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC + select GBB_FLAG_DISABLE_FWMP + +config FMDFILE + string + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/mc_bdx1.fmd" if VBOOT + config MAINBOARD_DIR string default "siemens/mc_bdx1" @@ -30,7 +43,7 @@
config CBFS_SIZE hex - default 0x00D00000 + default 0x00D00000 if !VBOOT
config VIRTUAL_ROM_SIZE hex diff --git a/src/mainboard/siemens/mc_bdx1/mc_bdx1.fmd b/src/mainboard/siemens/mc_bdx1/mc_bdx1.fmd new file mode 100644 index 0000000..cb7ef39 --- /dev/null +++ b/src/mainboard/siemens/mc_bdx1/mc_bdx1.fmd @@ -0,0 +1,25 @@ +FLASH@0xff000000 0x1000000 { + SI_ALL@0x0 0x300000 { + SI_DESC@0x0 0x1000 + SI_ME@0x1000 0x2ff000 + } + SI_BIOS@0x300000 0xd00000 { + RW_MRC_CACHE 0x10000 + RW_SHARED 0x4000 { + SHARED_DATA 0x2000 + VBLOCK_DEV 0x2000 + } + RW_VPD 0x2000 + RW_NVRAM 0x2000 + WP_RO 0xce8000 { + RO_VPD 0x4000 + RO_SECTION 0xce4000 { + FMAP 0x800 + RO_FRID 0x40 + RO_FRID_PAD 0x7c0 + GBB 0xef000 + COREBOOT(CBFS) + } + } + } +}
-
Arthur Heymans (Code Review) -
Mario Scheithauer (Code Review)
-
Werner Zeh (Code Review)