Attention is currently required from: Martin Roth, Paul Menzel, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50709 )
Change subject: sio/nuvoton/nct5572d: Add HWM API ......................................................................
Patch Set 2:
(3 comments)
File src/superio/nuvoton/nct5572d/nct5572d_hwm.h:
https://review.coreboot.org/c/coreboot/+/50709/comment/b761c661_d90e66db PS2, Line 32: enum nct5572d_hwm_temp_src { See https://github.com/torvalds/linux/blob/master/drivers/hwmon/nct6775.c#L350 for the correct values
File src/superio/nuvoton/nct5572d/nct5572d_hwm.c:
https://review.coreboot.org/c/coreboot/+/50709/comment/f6ade6b7_11e1f18f PS2, Line 56: pnp_write_hwm5_index(base, 0x04, tcp->step_down_time); https://github.com/torvalds/linux/blob/master/drivers/hwmon/nct6775.c#L396
STEP_UP_TIME and STEP_DOWN_TIME regs are swapped for all chips but NCT6775
https://review.coreboot.org/c/coreboot/+/50709/comment/c904d6bd_0c53216f PS2, Line 86: pnp_write_hwm5_index(base, 0x04, scp->step_down_time); Same here, these two are swapped