Change in ...coreboot[master]: arch/mips: Fix <arch/mmio.h> prototypes - coreboot-gerrit

20 Mar 2019


      Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31995 )
Change subject: arch/mips: Fix <arch/mmio.h> prototypes
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31995/4/src/arch/mips/include/arch/mmio.h 
File src/arch/mips/include/arch/mmio.h:
https://review.coreboot.org/#/c/31995/4/src/arch/mips/include/arch/mmio.h@68 
PS4, Line 68: #define write32_x(addr, val)	write32((void *)(addr), (val))
...
Why not just […]
Wait that needs to be... uhh...
Okay, I give up, you're right about the painful part. ;)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31995
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide8502ee8cda8995828c77fe1674d8ba6f3aa15f
Gerrit-Change-Number: 31995
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 20 Mar 2019 22:06:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment