Attention is currently required from: Elyes Haouas, Julius Werner, Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76883?usp=email )
Change subject: drivers/uart/pl011: Fix regwidth
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/uart/pl011.c:
https://review.coreboot.org/c/coreboot/+/76883/comment/520c4343_a55c9b57 :
PS1, Line 38: enum cb_err
out of scope
it returns something else than CB_SUCCESS ?
What else should it return?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76883?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I955319d31bba5c0cd4d50f2b34111d51fea653ed
Gerrit-Change-Number: 76883
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 03 Aug 2023 07:42:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment