Attention is currently required from: Felix Singer, Lance Zhao, Furquan Shaikh, Mariusz Szafrański, Tim Wawrzynczak, Paul Menzel, Suresh Bellampalli, Vanessa Eusebio, Subrata Banik, Angel Pons, Michal Motyl, Patrick Rudolph.
Hello Felix Singer, build bot (Jenkins), Furquan Shaikh, Mariusz Szafrański, Paul Menzel, Angel Pons, Subrata Banik, Patrick Rudolph, Lance Zhao, Nico Huber, Tim Wawrzynczak, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57934
to look at the new patch set (#20).
Change subject: soc/intel/{common,skl}: set ACPI_FADT_PLATFORM_CLOCK based on Kconfig
......................................................................
soc/intel/{common,skl}: set ACPI_FADT_PLATFORM_CLOCK based on Kconfig
uCode PM ACPI Timer emulation does not support `TMR_STS`. Any OS or
software relying on the overflow flag will not work properly. The FADT
contains a flag `ACPI_FADT_PLATFORM_CLOCK` telling the OSPM if a
specification-compliant PM Timer is present or not. Only set the flag,
when the hardware PM Timer is enabled.
Change-Id: Id2e5d69b5515c21e6ce922dab2cb88b494c65ebe
Signed-off-by: Michael Niewöhner foss@mniewoehner.de
---
M src/soc/intel/common/block/acpi/acpi.c
M src/soc/intel/skylake/fadt.c
2 files changed, 8 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/57934/20
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57934
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id2e5d69b5515c21e6ce922dab2cb88b494c65ebe
Gerrit-Change-Number: 57934
Gerrit-PatchSet: 20
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: newpatchset