Change in coreboot[master]: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines

List overview All Threads
Download

newer

older

Change in coreboot[master]: Fix...

Change in coreboot[master]:...

Angel Pons (Code Review)

7 Jul 2020 7 Jul '20

10:47 a.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43160 )

Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines ......................................................................

sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines

Looks like i82801ix and i82801jx have those. Adding them does no harm.

Change-Id: Iad9699709f3e90670f2d4f9b5664a048971ea412 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/i82801gx/acpi/globalnvs.asl 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/43160/1

diff --git a/src/southbridge/intel/i82801gx/acpi/globalnvs.asl b/src/southbridge/intel/i82801gx/acpi/globalnvs.asl index 848005d..0a0f255 100644 --- a/src/southbridge/intel/i82801gx/acpi/globalnvs.asl +++ b/src/southbridge/intel/i82801gx/acpi/globalnvs.asl @@ -15,6 +15,7 @@ Field (GNVS, ByteAcc, NoLock, Preserve) { /* Miscellaneous */ + Offset (0x00), OSYS, 16, // 0x00 - Operating System SMIF, 8, // 0x02 - SMI function PRM0, 8, // 0x03 - SMI function parameter @@ -32,6 +33,7 @@ LINX, 8, // 0x12 - Linux OS DCKN, 8, // 0x13 - PCIe docking state /* Thermal policy */ + Offset (0x14), ACTT, 8, // 0x14 - active trip point TPSV, 8, // 0x15 - passive trip point TC1V, 8, // 0x16 - passive trip point TC1 @@ -70,6 +72,7 @@ UTIL, 8, // 0x3a - ACIN, 8, // 0x3b - /* Integrated Graphics Device */ + Offset (0x3c), IGDS, 8, // 0x3c - IGD state (primary = 1) TLST, 8, // 0x3d - Display Toggle List pointer CADL, 8, // 0x3e - Currently Attached Devices List

Attachments:

attachment.htm (text/html — 3.3 KB)

Show replies by date

Paul Menzel (Code Review)

7 Jul 7 Jul

3:39 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43160 )

Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/43160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad9699709f3e90670f2d4f9b5664a048971ea412 Gerrit-Change-Number: 43160 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 07 Jul 2020 05:39:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

3:41 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43160 )

Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43160/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43160/1//COMMIT_MSG@10 PS1, Line 10: This basically reverts commit 80505a6fef (sb/intel/i82801gx: Remove unnecessary/redundant ACPI offset operator) [1][2].

I believe the IASL warnings/notes are now disabled in our environment.

[1]: If53072c6a91dd794c70d1fab8697b1713d400fe8 [2]: https://review.coreboot.org/c/31672

-- To view, visit https://review.coreboot.org/c/coreboot/+/43160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad9699709f3e90670f2d4f9b5664a048971ea412 Gerrit-Change-Number: 43160 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 07 Jul 2020 05:41:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

8:57 p.m.

Hello build bot (Jenkins), Paul Menzel, Patrick Rudolph, HAOUAS Elyes,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43160

to look at the new patch set (#2).

Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines ......................................................................

sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines

Looks like i82801ix and i82801jx have those. Adding them does no harm.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/43160/2

Angel Pons (Code Review)

9:09 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43160 )

Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43160/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43160/1//COMMIT_MSG@7 PS1, Line 7: h hell, you are drunk

https://review.coreboot.org/c/coreboot/+/43160/1//COMMIT_MSG@10 PS1, Line 10:

...

This basically reverts commit 80505a6fef (sb/intel/i82801gx: Remove unnecessary/redundant ACPI offse […]

Ah, just learned of that change. In any case, having them makes the ASL code easier to follow. Otherwise, one needs to count the bits from the last Offset line. Plus, it makes the globalnvs.asl files identical, which is nice.

Want me to do anything about it?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad9699709f3e90670f2d4f9b5664a048971ea412 Gerrit-Change-Number: 43160 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 07 Jul 2020 11:09:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

10:57 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43160 )

Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines ......................................................................

Patch Set 2: Code-Review-1

(1 comment)

extraneous/redundant uses of the Offset() are not needed :

OperationRegion (OPR1, SystemMemory, 0x100, 0x100) Field (OPR1) { Offset (0), // Never needed FLD1, 32, Offset (4), // Redundant, offset is already 4 (bytes) FLD2, 8, Offset (64), // OK use of Offset. FLD3, 16, }

will give :

dsdt.asl 14: Offset (0), Remark 2158 - ^ Unnecessary/redundant use of Offset operator

dsdt.asl 16: Offset (4), Remark 2158 - ^ Unnecessary/redundant use of Offset operator

https://review.coreboot.org/c/coreboot/+/43160/2/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/acpi/globalnvs.asl:

https://review.coreboot.org/c/coreboot/+/43160/2/src/southbridge/intel/i8280... PS2, Line 18: Offset (0x00), please remove this

-- To view, visit https://review.coreboot.org/c/coreboot/+/43160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad9699709f3e90670f2d4f9b5664a048971ea412 Gerrit-Change-Number: 43160 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 07 Jul 2020 12:57:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

11:46 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43160 )

Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines ......................................................................

Patch Set 2:

(1 comment)

...

Patch Set 2: Code-Review-1

(1 comment)

extraneous/redundant uses of the Offset() are not needed :
OperationRegion (OPR1, SystemMemory, 0x100, 0x100)
Field (OPR1)
{
    Offset (0),     // Never needed
    FLD1, 32,
    Offset (4),     // Redundant, offset is already 4 (bytes)
    FLD2, 8,
    Offset (64),    // OK use of Offset.
    FLD3, 16,
}

will give :

dsdt.asl 14: Offset (0), Remark 2158 - ^ Unnecessary/redundant use of Offset operator

dsdt.asl 16: Offset (4), Remark 2158 - ^ Unnecessary/redundant use of Offset operator

I don't see such warnings anywhere: https://paste.flashrom.org/view.php?id=3337

https://review.coreboot.org/c/coreboot/+/43160/2/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/acpi/globalnvs.asl:

https://review.coreboot.org/c/coreboot/+/43160/2/src/southbridge/intel/i8280... PS2, Line 18: Offset (0x00),

...

please remove this

Elyes, these are added for alignment purposes (i82801ix/i82801jx have them). This change makes globalnvs.asl for i82801{gx,ix,jx} *identical*

I can understand that Offset (0x00) is redundant, but I'd rather remove all instances of it on a separate commit. Does it sound good?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad9699709f3e90670f2d4f9b5664a048971ea412 Gerrit-Change-Number: 43160 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 07 Jul 2020 13:46:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

8 Jul 8 Jul

12:31 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43160 )

Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines ......................................................................

Patch Set 3:

...

Patch Set 2:

(1 comment)

...
Patch Set 2: Code-Review-1

(1 comment)

extraneous/redundant uses of the Offset() are not needed :
OperationRegion (OPR1, SystemMemory, 0x100, 0x100)
Field (OPR1)
{
    Offset (0),     // Never needed
    FLD1, 32,
    Offset (4),     // Redundant, offset is already 4 (bytes)
    FLD2, 8,
    Offset (64),    // OK use of Offset.
    FLD3, 16,
}

will give :

dsdt.asl 14: Offset (0), Remark 2158 - ^ Unnecessary/redundant use of Offset operator

dsdt.asl 16: Offset (4), Remark 2158 - ^ Unnecessary/redundant use of Offset operator
I don't see such warnings anywhere: https://paste.flashrom.org/view.php?id=3337

nano +267 Makefile.inc ;)

-- To view, visit https://review.coreboot.org/c/coreboot/+/43160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad9699709f3e90670f2d4f9b5664a048971ea412 Gerrit-Change-Number: 43160 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 07 Jul 2020 14:31:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

12:37 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43160 )

Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43160/2/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/acpi/globalnvs.asl:

https://review.coreboot.org/c/coreboot/+/43160/2/src/southbridge/intel/i8280... PS2, Line 18: Offset (0x00),

...

Elyes, these are added for alignment purposes (i82801ix/i82801jx have them). […]

I think you can remove redundant and make alignment to a clean file.

Please don't add them ... ( I spent time to remove many of them )

-- To view, visit https://review.coreboot.org/c/coreboot/+/43160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad9699709f3e90670f2d4f9b5664a048971ea412 Gerrit-Change-Number: 43160 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 07 Jul 2020 14:37:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

25 Jul 25 Jul

11:06 a.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43160 )

Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43160/4/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/acpi/globalnvs.asl:

https://review.coreboot.org/c/coreboot/+/43160/4/src/southbridge/intel/i8280... PS4, Line 18: Offset (0x00) This is the only one I'd complain about, because it's not very helpful. What about removing from i82801ix and i82801jx instead?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad9699709f3e90670f2d4f9b5664a048971ea412 Gerrit-Change-Number: 43160 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Sat, 25 Jul 2020 01:06:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

11:13 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43160 )

Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43160/4/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/acpi/globalnvs.asl:

https://review.coreboot.org/c/coreboot/+/43160/4/src/southbridge/intel/i8280... PS4, Line 18: Offset (0x00)

...

This is the only one I'd complain about, because it's not very helpful. […]

Sounds good. I think we can drop all `Offset (0x00)` instances, but keep the rest for clarity.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad9699709f3e90670f2d4f9b5664a048971ea412 Gerrit-Change-Number: 43160 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Sat, 25 Jul 2020 01:13:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

11:14 a.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43160 )

Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43160/4/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/acpi/globalnvs.asl:

https://review.coreboot.org/c/coreboot/+/43160/4/src/southbridge/intel/i8280... PS4, Line 18: Offset (0x00)

...

Sounds good. I think we can drop all `Offset (0x00)` instances, but keep the rest for clarity.

👍

-- To view, visit https://review.coreboot.org/c/coreboot/+/43160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad9699709f3e90670f2d4f9b5664a048971ea412 Gerrit-Change-Number: 43160 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Sat, 25 Jul 2020 01:14:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4:30 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43160 )

Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43160/4/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/acpi/globalnvs.asl:

https://review.coreboot.org/c/coreboot/+/43160/4/src/southbridge/intel/i8280... PS4, Line 18: Offset (0x00)

...

👍

please see https://review.coreboot.org/c/coreboot/+/43283 Thx

-- To view, visit https://review.coreboot.org/c/coreboot/+/43160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad9699709f3e90670f2d4f9b5664a048971ea412 Gerrit-Change-Number: 43160 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Sat, 25 Jul 2020 06:30:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

23 Feb 23 Feb

11:39 p.m.

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43160 )

Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/43160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad9699709f3e90670f2d4f9b5664a048971ea412 Gerrit-Change-Number: 43160 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: abandon

1322

days inactive

1553

days old

coreboot-gerrit@coreboot.org

13 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)
Paul Menzel (Code Review)
Tim Wawrzynczak (Code Review)