Attention is currently required from: Kane Chen, Tim Wawrzynczak, Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59355 )
Change subject: soc/intel/alderlake: remove tmp bar assignment for cpu crashlog ......................................................................
Patch Set 8:
(2 comments)
File src/soc/intel/alderlake/crashlog.c:
https://review.coreboot.org/c/coreboot/+/59355/comment/96d4efab_1593539d PS8, Line 213: printk(BIOS_DEBUG, "cpu crashlog bar addr: 0x%X\n", : pci_read_config32(SA_DEV_TMT, PCI_BASE_ADDRESS_0)); No need to read PCI config space then. Use the resources attached to the device.
const struct resource *res = find_resource(SA_DEV_TMT, PCI_BASE_ADDRESS_0); printk(BIOS_DEBUG, "cpu crashlog bar addr: 0x%lX\n", res->base);
https://review.coreboot.org/c/coreboot/+/59355/comment/7a40fc92_9e9bdf57 PS8, Line 221: m_cpu_crashLog_present = true; sidenote: This assignment seems meaningless