Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83397?usp=email )
Change subject: mb/google/rex: Refactor CSE config options for model-specific settings ......................................................................
mb/google/rex: Refactor CSE config options for model-specific settings
This patch refactors CSE config options, moving the selection of:
* `SOC_INTEL_CSE_LITE_SKU` * `SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY_V2` * `SOC_INTEL_CSE_SEND_EOP_ASYNC`
from the generic `BOARD_GOOGLE_REX_COMMON` to individual board models. This enables finer-grained control over CSE features and sync behavior on different Rex and variants platforms.
Specifically:
* `google/rex0`: Selects `SOC_INTEL_CSE_LITE_SKU` for CSE sync within coreboot. * `google/rex64`: Selects `SOC_INTEL_CSE_LITE_SYNC_BY_PAYLOAD` and `SOC_INTEL_CSE_SEND_EOP_BY_PAYLOAD` to defer CSE sync to the payload.
BUG=b:305898363 TEST=Builds successfully for google/rex variants.
Change-Id: Ib5957496b1e1dad8d135b3e10541cb83dd339539 Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83397 Reviewed-by: Nick Vaccaro nvaccaro@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/rex/Kconfig 1 file changed, 20 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Nick Vaccaro: Looks good to me, approved
diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig index 9ee0bc0..2ebcf32 100644 --- a/src/mainboard/google/rex/Kconfig +++ b/src/mainboard/google/rex/Kconfig @@ -28,9 +28,6 @@ select MB_COMPRESS_RAMSTAGE_LZ4 select PMC_IPC_ACPI_INTERFACE select SOC_INTEL_COMMON_BLOCK_VARIANT_POWER_LIMIT - select SOC_INTEL_CSE_LITE_SKU - select SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY_V2 - select SOC_INTEL_CSE_SEND_EOP_ASYNC
config BOARD_GOOGLE_BASEBOARD_OVIS def_bool n @@ -43,6 +40,9 @@ select RT8168_GEN_ACPI_POWER_RESOURCE select RT8168_GET_MAC_FROM_VPD select RT8168_SET_LED_MODE + select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY_V2 + select SOC_INTEL_CSE_SEND_EOP_ASYNC select SOC_INTEL_IOE_DIE_SUPPORT select SOC_INTEL_METEORLAKE_U_H select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES @@ -71,6 +71,9 @@ config BOARD_GOOGLE_MODEL_KARIS def_bool n select BOARD_GOOGLE_BASEBOARD_REX + select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY_V2 + select SOC_INTEL_CSE_SEND_EOP_ASYNC
config BOARD_GOOGLE_MODEL_OVIS def_bool n @@ -91,6 +94,9 @@ config BOARD_GOOGLE_MODEL_REX_EC_ISH def_bool n select BOARD_GOOGLE_MODEL_REX + select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY_V2 + select SOC_INTEL_CSE_SEND_EOP_ASYNC select SOC_INTEL_STORE_ISH_FW_VERSION
config BOARD_GOOGLE_MODEL_SCREEBO @@ -98,6 +104,9 @@ select BOARD_GOOGLE_BASEBOARD_REX select DRIVERS_GENERIC_ALC1015 select DRIVERS_GENESYSLOGIC_GL9750 + select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY_V2 + select SOC_INTEL_CSE_SEND_EOP_ASYNC
config BOARD_GOOGLE_DEKU select BOARD_GOOGLE_MODEL_DEKU @@ -121,10 +130,15 @@
config BOARD_GOOGLE_REX0 select BOARD_GOOGLE_MODEL_REX + select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY_V2 + select SOC_INTEL_CSE_SEND_EOP_ASYNC
config BOARD_GOOGLE_REX64 select BOARD_GOOGLE_MODEL_REX select HAVE_X86_64_SUPPORT + select SOC_INTEL_CSE_LITE_SYNC_BY_PAYLOAD + select SOC_INTEL_CSE_SEND_EOP_BY_PAYLOAD select USE_X86_64_SUPPORT
config BOARD_GOOGLE_REX_EC_ISH @@ -132,6 +146,9 @@
config BOARD_GOOGLE_REX4ES select BOARD_GOOGLE_MODEL_REX + select SOC_INTEL_CSE_LITE_SKU + select SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY_V2 + select SOC_INTEL_CSE_SEND_EOP_ASYNC select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON
config BOARD_GOOGLE_REX4ES_EC_ISH