Change in coreboot[master]: cpu/intel/microcode: Make microcode lib available in bootblock
Rizwan Qureshi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35278 )
Change subject: cpu/intel/microcode: Make microcode lib available in bootblock ......................................................................
cpu/intel/microcode: Make microcode lib available in bootblock
Make microcode lib available in bootblock.
Change-Id: I419da6af70222902e3ca39fc2133d5dc8558e053 Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com --- M src/cpu/intel/microcode/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/35278/1
diff --git a/src/cpu/intel/microcode/Makefile.inc b/src/cpu/intel/microcode/Makefile.inc index 2df1d5e..b13172e 100644 --- a/src/cpu/intel/microcode/Makefile.inc +++ b/src/cpu/intel/microcode/Makefile.inc @@ -1,5 +1,6 @@ bootblock-$(CONFIG_MICROCODE_UPDATE_PRE_RAM) += microcode_asm.S romstage-$(CONFIG_MICROCODE_UPDATE_PRE_RAM) += microcode_asm.S
+bootblock-$(CONFIG_SUPPORT_CPU_UCODE_IN_CBFS) += microcode.c ramstage-$(CONFIG_SUPPORT_CPU_UCODE_IN_CBFS) += microcode.c romstage-$(CONFIG_SUPPORT_CPU_UCODE_IN_CBFS) += microcode.c
Hello Patrick Rudolph, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35278
to look at the new patch set (#2).
Change subject: cpu/intel/microcode: Make microcode lib available in bootblock ......................................................................
cpu/intel/microcode: Make microcode lib available in bootblock
Make microcode lib available in bootblock. Now that microcode.c is compiled in bootlock no need to include it explicitly, hence remove its references and include the header file.
Change-Id: I419da6af70222902e3ca39fc2133d5dc8558e053 Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com --- M src/cpu/intel/fsp_model_406dx/bootblock.c M src/cpu/intel/haswell/bootblock.c M src/cpu/intel/microcode/Makefile.inc M src/cpu/intel/model_2065x/bootblock.c M src/cpu/intel/model_206ax/bootblock.c M src/soc/intel/baytrail/bootblock/bootblock.c M src/soc/intel/fsp_baytrail/bootblock/bootblock.c M src/soc/intel/fsp_broadwell_de/bootblock/bootblock.c 8 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/35278/2
Hello Patrick Rudolph, Subrata Banik, Huang Jin, Philipp Deppenwiese, build bot (Jenkins), David Guckian, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35278
to look at the new patch set (#3).
Change subject: cpu/intel/microcode: Make microcode lib available in bootblock ......................................................................
cpu/intel/microcode: Make microcode lib available in bootblock
Make microcode lib available in bootblock. Now that microcode.c is compiled in bootlock no need to include it explicitly, hence remove its references.
Change-Id: I419da6af70222902e3ca39fc2133d5dc8558e053 Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com --- M src/cpu/intel/haswell/bootblock.c M src/cpu/intel/microcode/Makefile.inc 2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/35278/3
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35278 )
Change subject: cpu/intel/microcode: Make microcode lib available in bootblock ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35278 )
Change subject: cpu/intel/microcode: Make microcode lib available in bootblock ......................................................................
cpu/intel/microcode: Make microcode lib available in bootblock
Make microcode lib available in bootblock. Now that microcode.c is compiled in bootlock no need to include it explicitly, hence remove its references.
Change-Id: I419da6af70222902e3ca39fc2133d5dc8558e053 Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35278 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/cpu/intel/haswell/bootblock.c M src/cpu/intel/microcode/Makefile.inc 2 files changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/cpu/intel/haswell/bootblock.c b/src/cpu/intel/haswell/bootblock.c index 37ce574..94e5d36 100644 --- a/src/cpu/intel/haswell/bootblock.c +++ b/src/cpu/intel/haswell/bootblock.c @@ -18,7 +18,6 @@ #include <arch/io.h> #include <halt.h>
-#include <cpu/intel/microcode/microcode.c> #include "haswell.h"
#include <southbridge/intel/lynxpoint/pch.h> diff --git a/src/cpu/intel/microcode/Makefile.inc b/src/cpu/intel/microcode/Makefile.inc index 2df1d5e..b13172e 100644 --- a/src/cpu/intel/microcode/Makefile.inc +++ b/src/cpu/intel/microcode/Makefile.inc @@ -1,5 +1,6 @@ bootblock-$(CONFIG_MICROCODE_UPDATE_PRE_RAM) += microcode_asm.S romstage-$(CONFIG_MICROCODE_UPDATE_PRE_RAM) += microcode_asm.S
+bootblock-$(CONFIG_SUPPORT_CPU_UCODE_IN_CBFS) += microcode.c ramstage-$(CONFIG_SUPPORT_CPU_UCODE_IN_CBFS) += microcode.c romstage-$(CONFIG_SUPPORT_CPU_UCODE_IN_CBFS) += microcode.c
-
Patrick Georgi (Code Review) -
Rizwan Qureshi (Code Review)