Attention is currently required from: Stefan Ott, Arthur Heymans, Kyösti Mälkki, Alexander Couzens, Elyes Haouas.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69447 )
Change subject: cpu/intel/socket_*: Clean up Kconfig files ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69447/comment/b33f68fc_60c2c3eb PS3, Line 10: Move MAX_CPUS to mainboards.
why?
Um, this reverts what was done in https://review.coreboot.org/q/topic:MAX_CPUS for seemingly no reason.
MAX_CPUS only specifies an upper bound (it's used to specify the size of some arrays), and it should be specified from socket and/or CPU Kconfig (it can also be specified from northbridge Kconfig if the CPU/socket situation is complicated).
In most cases, mainboards shouldn't specify MAX_CPUS. If a mainboard needs a larger value, one should raise the value in platform code instead. If a mainboard uses a smaller value for no good reason (no, "optimization" is not a good reason), then don't do it.
-
Angel Pons (Code Review)