Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39262 )
Change subject: intel/soc: skl,apl,cnl,icl,tgl,common: enable TCO SMIs ......................................................................
Patch Set 5:
Patch Set 5:
Patch Set 4:
Patch Set 4:
Patch Set 4: Code-Review-1
This should be made into an option. From a Chrome OS perspective we do not want to take SMIs for these events. It leads to having more complex handlers and the associated policy with them.
What is Chrome OS using instead?
We don't use TCO SMIs for anything. For intruder specifically we don't currently plumb anything up. For example, I don't want to take an SMI for a TCO timer expiration -- just want a reset on double expiration. Maybe we will in the future, but I don't want to enable TCO SMIs by default.
Hm, but why can't you just ignore the fact that maybe SMI are raised? It doesn't interfere with anything, does it? Currently there is no functionality implemented but it's just a stub to make that possible.
Don't get me wrong, I'm not against having an option for that. I just want to understand how that could affect Chrome OS or others.
I don't like taking unnecessary SMIs as it steals cycles and it adds more attack surface area.