Attention is currently required from: Hung-Te Lin, Shelley Chen, Ravi kumar, Paul Menzel, mturney mturney, Ravi Kumar Bokka, Angel Pons, Arthur Heymans, Xixi Chen, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59193 )
Change subject: libpayload: Parse DDR information through coreboot tables
......................................................................
Patch Set 35:
(3 comments)
Patchset:
PS32:
This is for getting the dram size in ramstage. […]
There seems to be very little overlap between that structure and the kind of information we care about here, so I don't think that would really work out. I guess we could consider reusing the smbios_memory_type enum if you want, though?
Patchset:
PS35:
Apologies for not getting back to this in a while, I haven't seen the end of my inbox since Perf started (and am clearly bad at prioritization).
File src/commonlib/bsd/include/commonlib/bsd/mem_chip_info.h:
https://review.coreboot.org/c/coreboot/+/59193/comment/1a9595d4_e63b5c03
PS32, Line 24: 2
I wasn't suggesting creating or using a linked-list. […]
Sorry for the confusion. This was always meant to be a variable-size array, that's why there *is* a channel_count field (see the `num_channels` above, that's exactly what that is for). All code that is reading this structure should read entries up to the number indicated in that field rather than just assume it is always 2. I didn't object to defining this array as length [2] in the struct because that made it easier to work with for now, but you are right that it should technically be length [0]. So since it already seems to be cause for confusion, let's change it to that.
There should not be a total_density field because that's just redundant with adding up the densities of all individual channels, and redundancy in informational structures is usually a bad idea (that just poses the risk of them going out of sync).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59193
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieca7e9fc0e1a018fcb2e9315aebee088edac858e
Gerrit-Change-Number: 59193
Gerrit-PatchSet: 35
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Xi Chen
xixi.chen@mediatek.com
Gerrit-CC: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: mturney mturney
quic_mturney@quicinc.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: mturney mturney
quic_mturney@quicinc.com
Gerrit-Comment-Date: Tue, 08 Mar 2022 01:07:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: mturney mturney
quic_mturney@quicinc.com
Gerrit-MessageType: comment