Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney, Sudheer Amrabadi.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59195 )
Change subject: soc/qualcomm/common: Add dram information to CBMEM table
......................................................................
Patch Set 24:
(1 comment)
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/59195/comment/46b910b3_0f8c6ea1
PS24, Line 27: {
Let's just check that te->size equals sizeof(struct mem_chip_info), and print an error (without setting the mem_chip_info pointer) when not. Then you don't need to store the size separately.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59195
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f1dd05ee224bf8284661c0afaa01d0a9d71daa7
Gerrit-Change-Number: 59195
Gerrit-PatchSet: 24
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: mturney mturney
quic_mturney@quicinc.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Attention: mturney mturney
quic_mturney@quicinc.com
Gerrit-Comment-Date: Tue, 08 Feb 2022 01:38:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment