Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31548 )
Change subject: security: Add memory subfolder ......................................................................
Patch Set 11:
(12 comments)
https://review.coreboot.org/#/c/31548/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31548/3//COMMIT_MSG@17 PS3, Line 17: TEE
explained
Ack
https://review.coreboot.org/#/c/31548/5/Documentation/security/memory_cleari... File Documentation/security/memory_clearing.md:
https://review.coreboot.org/#/c/31548/5/Documentation/security/memory_cleari... PS5, Line 14: bringup
bring-up?
Ack
https://review.coreboot.org/#/c/31548/5/Documentation/security/memory_cleari... PS5, Line 15: SoC
device?
Ack
https://review.coreboot.org/#/c/31548/5/Documentation/security/memory_cleari... PS5, Line 26: platforms
singular
Ack
https://review.coreboot.org/#/c/31548/5/Documentation/security/memory_cleari... PS5, Line 27: call
calls
Ack
https://review.coreboot.org/#/c/31548/3/src/security/memory/Kconfig File src/security/memory/Kconfig:
https://review.coreboot.org/#/c/31548/3/src/security/memory/Kconfig@16 PS3, Line 16: initilization
Done
Ack
https://review.coreboot.org/#/c/31548/3/src/security/memory/Kconfig@23 PS3, Line 23: (as part of FSP or coreboot).
Done
Ack
https://review.coreboot.org/#/c/31548/3/src/security/memory/Kconfig@34 PS3, Line 34: endmenu #Memory initilization
Done
Ack
https://review.coreboot.org/#/c/31548/3/src/security/memory/memory.h File src/security/memory/memory.h:
https://review.coreboot.org/#/c/31548/3/src/security/memory/memory.h@17 PS3, Line 17: #include <stddef.h>
Done
Kind of.
https://review.coreboot.org/#/c/31548/5/src/security/memory/memory.c File src/security/memory/memory.c:
https://review.coreboot.org/#/c/31548/5/src/security/memory/memory.c@28 PS5, Line 28: return 1; : : /* TODO: Add TEE environments here */ : : return 0;
Use `true` and `false` as the type is `bool`? The macros are defined in `stdint.h`.
Done
https://review.coreboot.org/#/c/31548/8/src/security/memory/memory.c File src/security/memory/memory.c:
https://review.coreboot.org/#/c/31548/8/src/security/memory/memory.c@27 PS8, Line 27: IS_ENABLED(CONFIG_
CONFIG(
Done
https://review.coreboot.org/#/c/31548/10/src/security/memory/memory.c File src/security/memory/memory.c:
https://review.coreboot.org/#/c/31548/10/src/security/memory/memory.c@17 PS10, Line 17: #include <stdint.h>
Needless include
`true` and `false` are used here, and indirect includes are discouraged. (that those are defined in the wrong header file is out of scope of this change)
-
Nico Huber (Code Review)