Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56609 )
Change subject: ec/roda/it8518/acpi: Remove unnecessary assignments ......................................................................
ec/roda/it8518/acpi: Remove unnecessary assignments
Simplify some operations to get rid of unnecessary assignments.
Change-Id: I02c93d42ce1de693d5d58fd9a29ccd5bff0f5978 Signed-off-by: Felix Singer felix.singer@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/56609 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/ec/roda/it8518/acpi/battery.asl M src/ec/roda/it8518/acpi/ec.asl 2 files changed, 4 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/ec/roda/it8518/acpi/battery.asl b/src/ec/roda/it8518/acpi/battery.asl index 7180ace..f164587 100644 --- a/src/ec/roda/it8518/acpi/battery.asl +++ b/src/ec/roda/it8518/acpi/battery.asl @@ -46,8 +46,7 @@
Local0 = 0x0f
- Local1 = ECPS - Local1 &= 0x02 + Local1 = ECPS & 0x02 If (Local1 == 0x02) { Local0 = 0x1f @@ -75,8 +74,7 @@ { Printf ("-----> BAT0: _BST")
- Local0 = B0ST - Local0 &= 0x40 + Local0 = B0ST & 0x40 If (Local0 == 0x40) { If (PWRS == 1) diff --git a/src/ec/roda/it8518/acpi/ec.asl b/src/ec/roda/it8518/acpi/ec.asl index 3b9a38d..fc241be 100644 --- a/src/ec/roda/it8518/acpi/ec.asl +++ b/src/ec/roda/it8518/acpi/ec.asl @@ -132,8 +132,7 @@ { Printf ("-----> EC: _Q43")
- Local0 = BRIG - Local0 += 1 + Local0 = BRIG + 1 If (Local0 > 0xaa) { Local0 = 0xaa } @@ -148,8 +147,7 @@ { Printf ("-----> EC: _Q44")
- Local0 = BRIG - Local0 -= 1 + Local0 = BRIG - 1 If (Local0 < 0xa0) { Local0 = 0xa0