Attention is currently required from: Martin Roth, Zanxi Chen, Henry Sun, Weimin Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51016 )
Change subject: mb/google/dedede/var/storo:Add P-sensor for storo
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/dedede/variants/storo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/51016/comment/d1faed5f_13dc0434
PS2, Line 47: [PchSerialIoIndexI2C0] = PchSerialIoPci,
It's refer to devicetree.cb in dedede/variant/baseboard, where has two space.
Then I’d say that the baseboard devicetree is “wrong”. (It looks like it is aligned with the = characters below, but that’s not useful.) It’d be nice to not make the same mistake here.
https://review.coreboot.org/c/coreboot/+/51016/comment/27478d49_d1964c08
PS2, Line 210: register "reg_gnrl_ctrl0" = "0x0a"
These values come from manufacturer, and the SAR Proximity Sensor has been used in other project of […]
Please mention that in the commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51016
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iced4ab7d94b38ef8b1807955cbb887454accb1e8
Gerrit-Change-Number: 51016
Gerrit-PatchSet: 3
Gerrit-Owner: Zanxi Chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Zanxi Chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Sun, 28 Feb 2021 21:02:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Zanxi Chen
chenzanxi@huaqin.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment