Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26133 )
Change subject: soc/intel/common/block: Move cse common functions into block/cse
......................................................................
Patch Set 37:
(1 comment)
https://review.coreboot.org/c/coreboot/+/26133/37/src/soc/intel/tigerlake/sm...
File src/soc/intel/tigerlake/smihandler.c:
https://review.coreboot.org/c/coreboot/+/26133/37/src/soc/intel/tigerlake/sm...
PS37, Line 37: heci_disable
Does TGL really support this?
yes, after CNP PCH all PCH will support this, use of SMM mode to make HECI function disable.
only exception was CMP due to dependency over CPU where SMM mode function disabling was not supported.
I remember we had this discussion on CML where you had mentioned that disabling of HECI might not be possible in SMM for CML and future platforms? Or am I remembering this incorrectly?
True for CML but not for future platforms. What we had proposed was that for future platform we will try to provide both options as FSP UPD to use PMC API for HECI function disable and continuing SMM mode support using coreboot. if i remember correctly, we have agreed to continue with coreboot support of disabling heci using SMM mode rather relying on FSP as CML due to more control in hand over FSP
--
To view, visit
https://review.coreboot.org/c/coreboot/+/26133
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22a4cc05d3967c7653d2abe2c829b4876516d179
Gerrit-Change-Number: 26133
Gerrit-PatchSet: 37
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 16 Feb 2020 17:14:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment