Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84182?usp=email )
Change subject: soc/intel: Remove unused `GPIO_IRQ_xxx` definitions ......................................................................
soc/intel: Remove unused `GPIO_IRQ_xxx` definitions
This patch removes the GPIO_IRQ_START and GPIO_IRQ_END definitions from itss.h for Alder Lake, Cannon Lake, Elkhart Lake, Jasper Lake, Meteor Lake and Tiger Lake. These definitions are no longer needed.
TEST=Able to build and boot google/xol and google/karis.
Change-Id: I60a08ba2c894fd1c1af6c6aef3ddc4a33ec63e76 Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/84182 Reviewed-by: Eric Lai ericllai@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/alderlake/include/soc/itss.h M src/soc/intel/cannonlake/include/soc/itss.h M src/soc/intel/elkhartlake/include/soc/itss.h M src/soc/intel/jasperlake/include/soc/itss.h M src/soc/intel/meteorlake/include/soc/itss.h M src/soc/intel/tigerlake/include/soc/itss.h 6 files changed, 0 insertions(+), 18 deletions(-)
Approvals: Eric Lai: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/soc/intel/alderlake/include/soc/itss.h b/src/soc/intel/alderlake/include/soc/itss.h index ff26c9f..0ea8ff1 100644 --- a/src/soc/intel/alderlake/include/soc/itss.h +++ b/src/soc/intel/alderlake/include/soc/itss.h @@ -3,9 +3,6 @@ #ifndef SOC_INTEL_ADL_ITSS_H #define SOC_INTEL_ADL_ITSS_H
-#define GPIO_IRQ_START 50 -#define GPIO_IRQ_END ITSS_MAX_IRQ - #define ITSS_MAX_IRQ 119 #define IRQS_PER_IPC 32 #define NUM_IPC_REGS ((ITSS_MAX_IRQ + IRQS_PER_IPC - 1)/IRQS_PER_IPC) diff --git a/src/soc/intel/cannonlake/include/soc/itss.h b/src/soc/intel/cannonlake/include/soc/itss.h index 59a2887f..902b8e2 100644 --- a/src/soc/intel/cannonlake/include/soc/itss.h +++ b/src/soc/intel/cannonlake/include/soc/itss.h @@ -3,9 +3,6 @@ #ifndef SOC_INTEL_CNL_ITSS_H #define SOC_INTEL_CNL_ITSS_H
-#define GPIO_IRQ_START 50 -#define GPIO_IRQ_END ITSS_MAX_IRQ - #define ITSS_MAX_IRQ 119 #define IRQS_PER_IPC 32 #define NUM_IPC_REGS ((ITSS_MAX_IRQ + IRQS_PER_IPC - 1)/IRQS_PER_IPC) diff --git a/src/soc/intel/elkhartlake/include/soc/itss.h b/src/soc/intel/elkhartlake/include/soc/itss.h index a550f4c..90a4af2 100644 --- a/src/soc/intel/elkhartlake/include/soc/itss.h +++ b/src/soc/intel/elkhartlake/include/soc/itss.h @@ -3,9 +3,6 @@ #ifndef SOC_INTEL_EHL_ITSS_H #define SOC_INTEL_EHL_ITSS_H
-#define GPIO_IRQ_START 50 -#define GPIO_IRQ_END ITSS_MAX_IRQ - #define ITSS_MAX_IRQ 119 #define IRQS_PER_IPC 32 #define NUM_IPC_REGS ((ITSS_MAX_IRQ + IRQS_PER_IPC - 1)/IRQS_PER_IPC) diff --git a/src/soc/intel/jasperlake/include/soc/itss.h b/src/soc/intel/jasperlake/include/soc/itss.h index c088865..ba1a1c2 100644 --- a/src/soc/intel/jasperlake/include/soc/itss.h +++ b/src/soc/intel/jasperlake/include/soc/itss.h @@ -3,9 +3,6 @@ #ifndef SOC_INTEL_JSL_ITSS_H #define SOC_INTEL_JSL_ITSS_H
-#define GPIO_IRQ_START 50 -#define GPIO_IRQ_END ITSS_MAX_IRQ - #define ITSS_MAX_IRQ 119 #define IRQS_PER_IPC 32 #define NUM_IPC_REGS ((ITSS_MAX_IRQ + IRQS_PER_IPC - 1)/IRQS_PER_IPC) diff --git a/src/soc/intel/meteorlake/include/soc/itss.h b/src/soc/intel/meteorlake/include/soc/itss.h index a0347d6..cee8245 100644 --- a/src/soc/intel/meteorlake/include/soc/itss.h +++ b/src/soc/intel/meteorlake/include/soc/itss.h @@ -3,9 +3,6 @@ #ifndef SOC_INTEL_MTL_ITSS_H #define SOC_INTEL_MTL_ITSS_H
-#define GPIO_IRQ_START 50 -#define GPIO_IRQ_END ITSS_MAX_IRQ - #define ITSS_MAX_IRQ 119 #define IRQS_PER_IPC 32 #define NUM_IPC_REGS ((ITSS_MAX_IRQ + IRQS_PER_IPC - 1)/IRQS_PER_IPC) diff --git a/src/soc/intel/tigerlake/include/soc/itss.h b/src/soc/intel/tigerlake/include/soc/itss.h index 20abbee..0291dc8 100644 --- a/src/soc/intel/tigerlake/include/soc/itss.h +++ b/src/soc/intel/tigerlake/include/soc/itss.h @@ -3,9 +3,6 @@ #ifndef SOC_INTEL_TGL_ITSS_H #define SOC_INTEL_TGL_ITSS_H
-#define GPIO_IRQ_START 50 -#define GPIO_IRQ_END ITSS_MAX_IRQ - #define ITSS_MAX_IRQ 119 #define IRQS_PER_IPC 32 #define NUM_IPC_REGS ((ITSS_MAX_IRQ + IRQS_PER_IPC - 1)/IRQS_PER_IPC)
-
Subrata Banik (Code Review)