Attention is currently required from: Caveh Jalali, Eric Lai, Alexander Couzens, Felix Held, Boris Mittelberg.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70846 )
Change subject: tree: Replace Or(a,b,c) with ASL 2.0 syntax
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/baytrail/acpi/lpss.asl:
https://review.coreboot.org/c/coreboot/+/70846/comment/3bf5604e_7607d9fb
PS3, Line 175: 0x00000000
for consistency with similar changes, this should be 0.
oops. Thanks!
are all these ORs with 0 effectively NOPs we could just remove?
That's a very good question. I don't know why they are there. And at this point I'm afraid to ask *insert meme*.
Since I'm just moving over to ASL 2.0 syntax I won't remove it here. That should be discussed in a separate change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70846
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf194b248075f290de90fb4bc4e9a0cd9d76ec61
Gerrit-Change-Number: 70846
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Sun, 18 Dec 2022 01:17:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment