Change in ...coreboot[master]: sb/i82801ix: Fix flashconsole on platform - coreboot-gerrit

4 Jun 2019


      Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21107 )
Change subject: sb/i82801ix: Fix flashconsole on platform
......................................................................
Patch Set 17: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/21107/17/src/mainboard/emulation/qemu-q35/Kc... 
File src/mainboard/emulation/qemu-q35/Kconfig:
https://review.coreboot.org/#/c/21107/17/src/mainboard/emulation/qemu-q35/Kc... 
PS17, Line 16: 	select TSC_MONOTONIC_TIMER
...
Does it emulate a SPI flash at all? if not, the right thing would be to […]
It doesn't make much sense for qemu to use flashconsole anyway
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/21107
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd3e8621fa4cb349b7e0e07118cab0380f24ff55
Gerrit-Change-Number: 21107
Gerrit-PatchSet: 17
Gerrit-Owner: Nicola Corna nicola@corna.info
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Huang Jin huang.jin@intel.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Nicola Corna nicola@corna.info
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: Youness Alaoui snifikino@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 04 Jun 2019 20:15:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment