Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69452 )
Change subject: soc/amd/picasso: add mb_pre_fspm() definition and weak implementation ......................................................................
soc/amd/picasso: add mb_pre_fspm() definition and weak implementation
On newer AMD platforms, mb_pre_fspm() is used to set GPIOs in romstage for PCIe reset (currently set in bootblock; will be moved in a subsequent commit) and touchscreen power sequencing (not yet implemented, but will be later in the patch train).
Change-Id: Ia422aaa9e80355f9a9f8f850368441e5c8ff6598 Signed-off-by: Matt DeVillier matt.devillier@amd.corp-partner.google.com --- M src/soc/amd/picasso/fsp_m_params.c M src/soc/amd/picasso/include/soc/platform_descriptors.h 2 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/69452/1
diff --git a/src/soc/amd/picasso/fsp_m_params.c b/src/soc/amd/picasso/fsp_m_params.c index 6483394..0be815e 100644 --- a/src/soc/amd/picasso/fsp_m_params.c +++ b/src/soc/amd/picasso/fsp_m_params.c @@ -5,6 +5,7 @@ #include <console/uart.h> #include <device/device.h> #include <fsp/api.h> +#include <soc/platform_descriptors.h> #include <soc/pci_devs.h> #include <soc/fsp.h> #include <types.h> @@ -12,6 +13,8 @@
void __weak mainboard_updm_update(FSP_M_CONFIG *mupd) {}
+void __weak mb_pre_fspm(void) {} + void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version) { FSP_M_CONFIG *mcfg = &mupd->FspmConfig; @@ -69,4 +72,5 @@ mcfg->pspp_policy = config->pspp_policy;
mainboard_updm_update(mcfg); + mb_pre_fspm(); } diff --git a/src/soc/amd/picasso/include/soc/platform_descriptors.h b/src/soc/amd/picasso/include/soc/platform_descriptors.h index 2ea35a9..00cd42f 100644 --- a/src/soc/amd/picasso/include/soc/platform_descriptors.h +++ b/src/soc/amd/picasso/include/soc/platform_descriptors.h @@ -27,4 +27,6 @@ const fsp_dxio_descriptor **dxio_descs, size_t *dxio_num, const fsp_ddi_descriptor **ddi_descs, size_t *ddi_num);
+void mb_pre_fspm(void); + #endif /* AMD_PICASSO_PLATFORM_DESCRIPTORS_H */