Attention is currently required from: Furquan Shaikh, Martin Roth, Angel Pons, Michal Motyl.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51180 )
Change subject: util/sconfig: Fix for multidomain support sconfig/devicetree.cb
......................................................................
Patch Set 3:
(2 comments)
File util/sconfig/main.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123974):
https://review.coreboot.org/c/coreboot/+/51180/comment/720cf6d6_60c97f13
PS3, Line 1311: fprintf(head, "extern DEVTREE_CONST void *const __pci_%d_%02x_%d_config;\n",
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123974):
https://review.coreboot.org/c/coreboot/+/51180/comment/bbe5fbae_1d5cdfcc
PS3, Line 1313: fprintf(fil, "DEVTREE_CONST void *const __pci_%d_%02x_%d_config = &%s_info_%d;\n",
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51180
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd639d0cb3ed1a49ed7c7b1c77ac747ba6f77672
Gerrit-Change-Number: 51180
Gerrit-PatchSet: 3
Gerrit-Owner: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Comment-Date: Tue, 13 Jul 2021 17:00:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment