Attention is currently required from: Gwendal Grignou.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59608 )
Change subject: driver/i2c: Add sx9360 driver
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
File src/drivers/i2c/sx9360/sx9360.c:
https://review.coreboot.org/c/coreboot/+/59608/comment/703b9ac5_25450c3e
PS4, Line 76: #undef REGISTER
what is this for?
https://review.coreboot.org/c/coreboot/+/59608/comment/2bd9b542_135788b2
PS4, Line 95: struct drivers_i2c_sx9360_config *config = dev->chip_info;
:
: if (!config) {
: dev->enabled = 0;
: return;
: }
```
if (!is_dev_enabled(dev))
return;
```
should be good enough
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59608
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a912f184e6f3501f894cca24c0d71a2c3087516
Gerrit-Change-Number: 59608
Gerrit-PatchSet: 4
Gerrit-Owner: Gwendal Grignou
gwendal@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Gwendal Grignou
gwendal@chromium.org
Gerrit-Comment-Date: Tue, 21 Dec 2021 22:21:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment