Attention is currently required from: Paul Menzel, Mario Scheithauer, Arthur Heymans, Andrey Petrov. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64426 )
Change subject: driver/intel/fsp2_0: Disable NULL deref code on some FSP ......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS3: Let's just do it for all FSP. The spec says to disable interrupts. Debug registers are not interrupts but exceptions... However this problem seems to be so common that it makes sense to generally disable this feature when entering FSP.
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/64426/comment/14a7a79f_3ba9a063 PS2, Line 388: acces
access
Done
File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/64426/comment/d2fec047_638575b7 PS2, Line 297: if (CONFIG(FSP_ACCESSES_NULL_WORKAROUND)) : null_breakpoint_disable(); : post_code(POST_FSP_MEMORY_INIT); : timestamp_add_now(TS_FSP_MEMORY_INIT_START); : if (ENV_X86_64 && CONFIG(PLATFORM_USES_FSP2_X86_32)) : status = protected_mode_call_2arg(fsp_raminit, : (uintptr_t)&fspm_upd, : (uintptr_t)fsp_get_hob_list_ptr()); : else : status = fsp_raminit(&fspm_upd, fsp_get_hob_list_ptr()); : if (CONFIG(FSP_ACCESSES_NULL_WORKAROUND)) : null_breakpoint_init(); :
Can you please implement this for silicon init (silicon_init.c) as well? […]
Done