Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47574 )
Change subject: util/cbfstool/amdcompress: fix short option for maxsize ......................................................................
util/cbfstool/amdcompress: fix short option for maxsize
Both the help and the maxsize option had the same short option character assigned. Change the short option for maxsize to m to fix this and to make it consistent with the rest of the code.
Change-Id: Icac1a7d4906345c37a5c7bed2b4995fea25f860e Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M util/cbfstool/amdcompress.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/47574/1
diff --git a/util/cbfstool/amdcompress.c b/util/cbfstool/amdcompress.c index eae347f..2a1d5c6 100644 --- a/util/cbfstool/amdcompress.c +++ b/util/cbfstool/amdcompress.c @@ -30,7 +30,7 @@ {"infile", required_argument, 0, 'i' }, {"outfile", required_argument, 0, 'o' }, {"compress", no_argument, 0, 'c' }, - {"maxsize", required_argument, 0, 'h' }, + {"maxsize", required_argument, 0, 'm' }, {"uncompress", no_argument, 0, 'u' }, {"help", no_argument, 0, 'h' }, };
Felix Held has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/47574 )
Change subject: util/cbfstool/amdcompress: fix short option for maxsize ......................................................................
util/cbfstool/amdcompress: fix short option for maxsize
Both the help and the maxsize option had the same short option character assigned. Change the short option for maxsize to m to fix this and to make it consistent with the rest of the code.
Change-Id: Icac1a7d4906345c37a5c7bed2b4995fea25f860e Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M util/cbfstool/amdcompress.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/47574/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47574
to look at the new patch set (#4).
Change subject: util/cbfstool/amdcompress: fix short option for maxsize ......................................................................
util/cbfstool/amdcompress: fix short option for maxsize
Both the help and the maxsize option had the same short option character assigned. Change the short option for maxsize to m to fix this and to make it consistent with the rest of the code.
Change-Id: Icac1a7d4906345c37a5c7bed2b4995fea25f860e Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M util/cbfstool/amdcompress.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/47574/4
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47574 )
Change subject: util/cbfstool/amdcompress: fix short option for maxsize ......................................................................
Patch Set 4: Code-Review+1
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47574 )
Change subject: util/cbfstool/amdcompress: fix short option for maxsize ......................................................................
Patch Set 4: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47574 )
Change subject: util/cbfstool/amdcompress: fix short option for maxsize ......................................................................
util/cbfstool/amdcompress: fix short option for maxsize
Both the help and the maxsize option had the same short option character assigned. Change the short option for maxsize to m to fix this and to make it consistent with the rest of the code.
Change-Id: Icac1a7d4906345c37a5c7bed2b4995fea25f860e Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/47574 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M util/cbfstool/amdcompress.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Marshall Dawson: Looks good to me, approved
diff --git a/util/cbfstool/amdcompress.c b/util/cbfstool/amdcompress.c index b4e10a2..ad6a039 100644 --- a/util/cbfstool/amdcompress.c +++ b/util/cbfstool/amdcompress.c @@ -30,7 +30,7 @@ {"infile", required_argument, 0, 'i' }, {"outfile", required_argument, 0, 'o' }, {"compress", required_argument, 0, 'c' }, - {"maxsize", required_argument, 0, 'h' }, + {"maxsize", required_argument, 0, 'm' }, {"uncompress", required_argument, 0, 'u' }, {"help", no_argument, 0, 'h' }, };
-
Felix Held (Code Review) -
Kyösti Mälkki (Code Review)
-
Marshall Dawson (Code Review)