Krystian Hebel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31674
Change subject: superio/ite/common/env_ctrl.c: fix IS_ENABLED argument ......................................................................
superio/ite/common/env_ctrl.c: fix IS_ENABLED argument
There was CONFIG_ prefix missing in SUPERIO_ITE_ENV_CTRL_FAN16_CONFIG option, this patch fixes it.
Signed-off-by: Krystian Hebel krystian.hebel@3mdeb.com Change-Id: I52919671569175141560cb73e42344aa1725c112 --- M src/superio/ite/common/env_ctrl.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/31674/1
diff --git a/src/superio/ite/common/env_ctrl.c b/src/superio/ite/common/env_ctrl.c index 1dc5bb6..92c9bca 100644 --- a/src/superio/ite/common/env_ctrl.c +++ b/src/superio/ite/common/env_ctrl.c @@ -213,7 +213,7 @@ ite_ec_write(base, ITE_EC_FAN_CTL_MODE, reg); }
- if (IS_ENABLED(SUPERIO_ITE_ENV_CTRL_FAN16_CONFIG) + if (IS_ENABLED(CONFIG_SUPERIO_ITE_ENV_CTRL_FAN16_CONFIG) && conf->mode >= FAN_MODE_ON) { reg = ite_ec_read(base, ITE_EC_FAN_TAC_COUNTER_ENABLE); reg |= ITE_EC_FAN_TAC_16BIT_ENABLE(fan);
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31674 )
Change subject: superio/ite/common/env_ctrl.c: fix IS_ENABLED argument ......................................................................
Patch Set 1: Code-Review+2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31674 )
Change subject: superio/ite/common/env_ctrl.c: fix IS_ENABLED argument ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31674 )
Change subject: superio/ite/common/env_ctrl.c: fix IS_ENABLED argument ......................................................................
superio/ite/common/env_ctrl.c: fix IS_ENABLED argument
There was CONFIG_ prefix missing in SUPERIO_ITE_ENV_CTRL_FAN16_CONFIG option, this patch fixes it.
Signed-off-by: Krystian Hebel krystian.hebel@3mdeb.com Change-Id: I52919671569175141560cb73e42344aa1725c112 Reviewed-on: https://review.coreboot.org/c/31674 Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/superio/ite/common/env_ctrl.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Felix Held: Looks good to me, approved
diff --git a/src/superio/ite/common/env_ctrl.c b/src/superio/ite/common/env_ctrl.c index 1dc5bb6..92c9bca 100644 --- a/src/superio/ite/common/env_ctrl.c +++ b/src/superio/ite/common/env_ctrl.c @@ -213,7 +213,7 @@ ite_ec_write(base, ITE_EC_FAN_CTL_MODE, reg); }
- if (IS_ENABLED(SUPERIO_ITE_ENV_CTRL_FAN16_CONFIG) + if (IS_ENABLED(CONFIG_SUPERIO_ITE_ENV_CTRL_FAN16_CONFIG) && conf->mode >= FAN_MODE_ON) { reg = ite_ec_read(base, ITE_EC_FAN_TAC_COUNTER_ENABLE); reg |= ITE_EC_FAN_TAC_16BIT_ENABLE(fan);
-
Felix Held (Code Review) -
Krystian Hebel (Code Review)
-
Nico Huber (Code Review)