HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36264 )
Change subject: src/ec/quanta: Drop wrong _ADR objects ......................................................................
src/ec/quanta: Drop wrong _ADR objects
Use _HID but not _HID and _ADR at the same time.
Found-by: ACPICA 20191018 Change-Id: Iaa35790a38c36091a228007d739b970cb66a3e1c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/ec/quanta/ene_kb3940q/acpi/superio.asl M src/ec/quanta/it8518/acpi/superio.asl 2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/36264/1
diff --git a/src/ec/quanta/ene_kb3940q/acpi/superio.asl b/src/ec/quanta/ene_kb3940q/acpi/superio.asl index 2f5298a..88dccc9 100644 --- a/src/ec/quanta/ene_kb3940q/acpi/superio.asl +++ b/src/ec/quanta/ene_kb3940q/acpi/superio.asl @@ -24,7 +24,6 @@ Device (PS2K) // Keyboard { Name (_UID, 0) - Name (_ADR, 0) Name (_HID, EISAID("PNP0303")) Name (_CID, EISAID("PNP030B"))
diff --git a/src/ec/quanta/it8518/acpi/superio.asl b/src/ec/quanta/it8518/acpi/superio.asl index e912e04..4109cb5 100644 --- a/src/ec/quanta/it8518/acpi/superio.asl +++ b/src/ec/quanta/it8518/acpi/superio.asl @@ -25,7 +25,6 @@ Device (PS2K) // Keyboard { Name (_UID, 0) - Name (_ADR, 0) Name (_HID, EISAID("PNP0303")) Name (_CID, EISAID("PNP030B"))
HAOUAS Elyes has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/36264 )
Change subject: src/ec/quanta: Drop wrong _ADR objects ......................................................................
src/ec/quanta: Drop wrong _ADR objects
Use _HID but not _HID and _ADR at the same time.
Found-by: ACPICA 20191018 Change-Id: Iaa35790a38c36091a228007d739b970cb66a3e1c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/ec/quanta/ene_kb3940q/acpi/superio.asl M src/ec/quanta/it8518/acpi/superio.asl 2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/36264/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36264
to look at the new patch set (#3).
Change subject: src/ec/quanta: Drop wrong _ADR objects ......................................................................
src/ec/quanta: Drop wrong _ADR objects
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Found-by: ACPICA 20191018 Change-Id: Iaa35790a38c36091a228007d739b970cb66a3e1c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/ec/quanta/ene_kb3940q/acpi/superio.asl M src/ec/quanta/it8518/acpi/superio.asl 2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/36264/3
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36264 )
Change subject: src/ec/quanta: Drop wrong _ADR objects ......................................................................
Patch Set 3: Code-Review+2