Attention is currently required from: Bora Guvendik, Subrata Banik, Wonkyu Kim.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83153?usp=email )
Change subject: src/lib: Add Kconfig variable for fw_config default value
......................................................................
Patch Set 1:
(1 comment)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/83153/comment/b81afae3_6f398b6f?usp... :
PS1, Line 548: 0x01000
Is there any reason why this value is no-zero value?
okay. undefined value is non-zero, I will change default value to '0'
./src/include/fw_config.h:
#define UNDEFINED_FW_CONFIG ~((uint64_t)0)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83153?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9694433e01bdcd9ff1e550585c14ea7ccee020a3
Gerrit-Change-Number: 83153
Gerrit-PatchSet: 1
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Mon, 24 Jun 2024 17:41:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com