Lin Huang has posted comments on this change. ( https://review.coreboot.org/23515 )
Change subject: rockchip/rk3399: add the delay time between saradc power up and start command
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/23515/1/src/soc/rockchip/rk3399/saradc.c
File src/soc/rockchip/rk3399/saradc.c:
https://review.coreboot.org/#/c/23515/1/src/soc/rockchip/rk3399/saradc.c@74
PS1, Line 74: udelay(SARADC_DELAY_PU);
This jumps from 250us to 8ms, which puts it well within the "uncomfortable" range of boot delays for […]
i will modify it to 4M and do the test again.
--
To view, visit
https://review.coreboot.org/23515
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42e49ca63299479912fa05e2a62cba6f2de4b337
Gerrit-Change-Number: 23515
Gerrit-PatchSet: 1
Gerrit-Owner: Lin Huang
hl@rock-chips.com
Gerrit-Reviewer: Brian Norris
briannorris@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lin Huang
hl@rock-chips.com
Gerrit-Reviewer: Philip Chen
philipchen@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 31 Jan 2018 07:09:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No