Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Li Jinfeng, Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69500 )
Change subject: src/soc/intel/xeon_sp/ras/hest.c: fix HEST table length
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
Patchset:
PS3:
The whole table generation is just plain wrong. I don't think it makes sense to just fix the returned without fixing the actual table genereation.
File src/soc/intel/xeon_sp/ras/hest.c:
https://review.coreboot.org/c/coreboot/+/69500/comment/bbdb5420_91cae2c8
PS3, Line 62: void *current;
: current = (void *)(hest);
: void *next = current;
: next = hest + 1;
Arithmetics on pointers to void is not defined in C. Gcc does accept it and sets size to 1 but it's not portable. Also it looks plain wrong. next will be right in the middle of the header. Look at the stoneyridge code on how it might be done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69500
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4780785bac782aa966def3f042f365a1ead9d9d8
Gerrit-Change-Number: 69500
Gerrit-PatchSet: 3
Gerrit-Owner: Li Jinfeng
lijinfeng01@inspur.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Li Jinfeng
lijinfeng01@inspur.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Sat, 12 Nov 2022 14:22:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment