Change in coreboot[master]: mb/google/volteer: Enable CSE Board Reset Override

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44684 )

Change subject: mb/google/volteer: Enable CSE Board Reset Override
......................................................................

mb/google/volteer: Enable CSE Board Reset Override

This will ensure that the cold reset is performed when CSE Lite jumps
from RO to RW.

BUG=b:162977697
TEST=Verify CSE reset is cold (sits in S5 for PCH Min Slp Duration time)

Change-Id: Ib1173e219ba46ee3275824220c8cf790b1d497fa
Signed-off-by: Tim Wawrzynczak 
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/mainboard.c
2 files changed, 1 insertion(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/44684/1

diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig
index baa71cb..ef631ca 100644
--- a/src/mainboard/google/volteer/Kconfig
+++ b/src/mainboard/google/volteer/Kconfig
@@ -1,6 +1,7 @@
 config BOARD_GOOGLE_BASEBOARD_VOLTEER
    def_bool n
    select BOARD_ROMSIZE_KB_32768
+	select CHROMEOS_CSE_BOARD_RESET_OVERRIDE
    select DRIVERS_GENERIC_GPIO_KEYS
    select DRIVERS_GENERIC_MAX98357A
    select DRIVERS_I2C_GENERIC
diff --git a/src/mainboard/google/volteer/mainboard.c b/src/mainboard/google/volteer/mainboard.c
index a926673..5bece68 100644
--- a/src/mainboard/google/volteer/mainboard.c
+++ b/src/mainboard/google/volteer/mainboard.c
@@ -5,19 +5,10 @@
 #include <baseboard/variants.h>
 #include <device/device.h>
 #include <ec/ec.h>
-#include <ec/google/chromeec/ec.h>
-#include <halt.h>
-#include <intelblocks/cse.h>
 #include <soc/gpio.h>
 #include <vendorcode/google/chromeos/chromeos.h>
 #include <variant/gpio.h>

-void cse_board_reset(void)
-{
-	if (!google_chromeec_ap_reset())
-		halt();
-}
-
 static void mainboard_init(struct device *dev)
 {
    mainboard_ec_init();

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44684 )

Change subject: mb/google/volteer: Enable CSE Board Reset Override
......................................................................

Patch Set 1: Code-Review+2

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44684 )

Change subject: mb/google/volteer: Enable CSE Board Reset Override
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44684/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/Kconfig:

https://review.coreboot.org/c/coreboot/+/44684/1/src/mainboard/google/voltee... 
PS1, Line 4: CHROMEOS_CSE_BOARD_RESET_OVERRIDE
Probably needs to be selected as part of CHROMEOS. I think that is the cause of the build failure.

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44684 )

Change subject: mb/google/volteer: Enable CSE Board Reset Override
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44684/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/Kconfig:

https://review.coreboot.org/c/coreboot/+/44684/1/src/mainboard/google/voltee... 
PS1, Line 4: CHROMEOS_CSE_BOARD_RESET_OVERRIDE
> Probably needs to be selected as part of CHROMEOS. I think that is the cause of the build failure.

You bet, thanks!

[Nick Vaccaro (Code Review)]

Nick Vaccaro has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/44684 )

Change subject: mb/google/volteer: Enable CSE Board Reset Override
......................................................................

Removed Code-Review+2 by Nick Vaccaro

[Tim Wawrzynczak (Code Review)]

Hello build bot (Jenkins), Caveh Jalali, Nick Vaccaro, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44684

to look at the new patch set (#2).

Change subject: mb/google/volteer: Enable CSE Board Reset Override
......................................................................

mb/google/volteer: Enable CSE Board Reset Override

This will ensure that the cold reset is performed when CSE Lite jumps
from RO to RW.

BUG=b:162977697
TEST=Verify CSE reset is cold (sits in S5 for PCH Min Slp Duration time)

Change-Id: Ib1173e219ba46ee3275824220c8cf790b1d497fa
Signed-off-by: Tim Wawrzynczak 
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/mainboard.c
2 files changed, 1 insertion(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/44684/2

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44684 )

Change subject: mb/google/volteer: Enable CSE Board Reset Override
......................................................................

Patch Set 2: Code-Review+2

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44684 )

Change subject: mb/google/volteer: Enable CSE Board Reset Override
......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/44684/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/Kconfig:

https://review.coreboot.org/c/coreboot/+/44684/1/src/mainboard/google/voltee... 
PS1, Line 4: CHROMEOS_CSE_BOARD_RESET_OVERRIDE
> You bet, thanks!

Done

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44684 )

Change subject: mb/google/volteer: Enable CSE Board Reset Override
......................................................................

mb/google/volteer: Enable CSE Board Reset Override

This will ensure that the cold reset is performed when CSE Lite jumps
from RO to RW.

BUG=b:162977697
TEST=Verify CSE reset is cold (sits in S5 for PCH Min Slp Duration time)

Change-Id: Ib1173e219ba46ee3275824220c8cf790b1d497fa
Signed-off-by: Tim Wawrzynczak 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44684
Tested-by: build bot (Jenkins) 
Reviewed-by: Caveh Jalali 
Reviewed-by: Karthik Ramasubramanian 
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/mainboard.c
2 files changed, 1 insertion(+), 9 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Caveh Jalali: Looks good to me, approved
  Karthik Ramasubramanian: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig
index baa71cb..4867fea 100644
--- a/src/mainboard/google/volteer/Kconfig
+++ b/src/mainboard/google/volteer/Kconfig
@@ -33,6 +33,7 @@
 config CHROMEOS
    bool
    default y
+	select CHROMEOS_CSE_BOARD_RESET_OVERRIDE if SOC_INTEL_CSE_LITE_SKU
    select EC_GOOGLE_CHROMEEC_SWITCHES
    select GBB_FLAG_FORCE_DEV_SWITCH_ON
    select GBB_FLAG_FORCE_DEV_BOOT_USB
diff --git a/src/mainboard/google/volteer/mainboard.c b/src/mainboard/google/volteer/mainboard.c
index a926673..5bece68 100644
--- a/src/mainboard/google/volteer/mainboard.c
+++ b/src/mainboard/google/volteer/mainboard.c
@@ -5,19 +5,10 @@
 #include <baseboard/variants.h>
 #include <device/device.h>
 #include <ec/ec.h>
-#include <ec/google/chromeec/ec.h>
-#include <halt.h>
-#include <intelblocks/cse.h>
 #include <soc/gpio.h>
 #include <vendorcode/google/chromeos/chromeos.h>
 #include <variant/gpio.h>

-void cse_board_reset(void)
-{
-	if (!google_chromeec_ap_reset())
-		halt();
-}
-
 static void mainboard_init(struct device *dev)
 {
    mainboard_ec_init();