Change in coreboot[master]: soc/amd/common/block/include/psp_efs: use unsigned type for bitfield - coreboot-gerrit

12 Oct 2021


      Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58224 )
Change subject: soc/amd/common/block/include/psp_efs: use unsigned type for bitfield
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/include/amdblocks/psp_efs.h:
https://review.coreboot.org/c/coreboot/+/58224/comment/fff433e0_1757e458 
PS1, Line 29: uint32_t
Why not use the generic type `unsigned int`?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58224
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic630d1709174d90336746bc37da504437c12643c
Gerrit-Change-Number: 58224
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 11 Oct 2021 21:27:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment