Attention is currently required from: Chen Wisley, Wisley Chen.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59269 )
Change subject: mb/google/brya/var/redrix: De-assert SSD PERST# in romstage
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59269/comment/2062d5a2_f58b4d72
PS1, Line 11:
suggestion: add something like
```
The reason for this is to give enough time after PERST#
deassertion so that the SSD has enough time to initialize before the FSP scans the RPs for downstream devices.
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59269
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I242cb1517f564d9d135d523b1e7f95ac34d601f8
Gerrit-Change-Number: 59269
Gerrit-PatchSet: 1
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Fri, 12 Nov 2021 21:05:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment