Change in coreboot[master]: util/cbmem: Add FlameGraph-compatible timestamps output - coreboot-gerrit

17 Mar 2022


      Attention is currently required from: Jakub Czapiga, Paul Menzel, Alex Levin, Julius Werner, Jan Dabros.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62474 )
Change subject: util/cbmem: Add FlameGraph-compatible timestamps output
......................................................................
Patch Set 9:
(1 comment)
File util/cbmem/cbmem.c:
https://review.coreboot.org/c/coreboot/+/62474/comment/51d345f1_0d000cc2 
PS8, Line 629: ::
...
What range indicator should we use? Slash is too "small" and makes everything look like a blob. […]
yeah I kinda like the `::`, I can't think of anything better
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62474
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a4e20a267e9e0fbc6b3a4d6a2409b32ce8fca33
Gerrit-Change-Number: 62474
Gerrit-PatchSet: 9
Gerrit-Owner: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Alex Levin levinale@google.com
Gerrit-Reviewer: Jan Dabros jsd@semihalf.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jakub Czapiga jacz@semihalf.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Alex Levin levinale@google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Jan Dabros jsd@semihalf.com
Gerrit-Comment-Date: Thu, 17 Mar 2022 17:08:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga jacz@semihalf.com
Gerrit-MessageType: comment