Attention is currently required from: Matt DeVillier, Paul Menzel.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/81409?usp=email )
Change subject: i2c/drivers/generic: Add support for including a CDM ......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81409/comment/e621e66b_af40a52d?usp... : PS5, Line 10: in mounted
i*s* mounted
Done
https://review.coreboot.org/c/coreboot/+/81409/comment/304a9e8d_a3908dfb?usp... : PS5, Line 13: rotating the device : and checking the orientation is correct
So before, that was wrong? […]
Yes, the horizontal axis was inverted. The accelerometer tells it which way is up relative to itself, so if it's mounted on the board upside down, OS needs to know that to interpret it correctly.