Ravishankar Sarawadi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44628 )
Change subject: mb/google/volteer*: Enable IPU ......................................................................
mb/google/volteer*: Enable IPU
Enable IPU for Volteer and Volteer2 variants for MIPI camera.
BUG=None BRANCH=None TEST=IPU is enabled and shows in lspci.
Signed-off-by: Ravi Sarawadi ravishankar.sarawadi@intel.com Change-Id: I66d60474e16c7a9aa8006d42b22510c1495dbd84 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb M src/mainboard/google/volteer/variants/volteer2/overridetree.cb 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/44628/1
diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb index b4948ec..2ef9fc9 100644 --- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb @@ -48,6 +48,7 @@ register "IomTypeCPortPadCfg[1]" = "0x090E000D"
device domain 0 on + device pci 05.0 on end # IPU 0x9A19 device pci 15.0 on chip drivers/i2c/generic register "hid" = ""10EC5682"" diff --git a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb index 3036a48..0bb82f1 100644 --- a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb @@ -6,6 +6,7 @@ register "DdiPort2Hpd" = "0"
device domain 0 on + device pci 05.0 on end # IPU 0x9A19 device pci 15.0 on chip drivers/i2c/generic register "hid" = ""10EC5682""
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44628 )
Change subject: mb/google/volteer*: Enable IPU ......................................................................
Patch Set 1: Code-Review+1
Daniel H Kang has uploaded a new patch set (#2) to the change originally created by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/44628 )
Change subject: mb/google/volteer*: Enable IPU ......................................................................
mb/google/volteer*: Enable IPU
Enable IPU for Volteer and Volteer2 variants for MIPI camera.
BUG=165340186 BRANCH=None TEST=IPU is enabled and shows in lspci.
Signed-off-by: Ravi Sarawadi ravishankar.sarawadi@intel.com Change-Id: I66d60474e16c7a9aa8006d42b22510c1495dbd84 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb M src/mainboard/google/volteer/variants/volteer2/overridetree.cb 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/44628/2
Daniel H Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44628 )
Change subject: mb/google/volteer*: Enable IPU ......................................................................
Patch Set 2: Code-Review+1
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44628 )
Change subject: mb/google/volteer*: Enable IPU ......................................................................
Patch Set 2: Code-Review+2
Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44628 )
Change subject: mb/google/volteer*: Enable IPU ......................................................................
Patch Set 2:
Could we get this
Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44628 )
Change subject: mb/google/volteer*: Enable IPU ......................................................................
Patch Set 2:
Could we get this CL merged as well? Thanks !
Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44628 )
Change subject: mb/google/volteer*: Enable IPU ......................................................................
Patch Set 2:
If no more review comments can we get this CL merged please. Thanks !
Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44628 )
Change subject: mb/google/volteer*: Enable IPU ......................................................................
Patch Set 2:
Since Volteer camera is broken in the recent CPFEs, would like to merge this patch as early as possible.
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44628 )
Change subject: mb/google/volteer*: Enable IPU ......................................................................
mb/google/volteer*: Enable IPU
Enable IPU for Volteer and Volteer2 variants for MIPI camera.
BUG=165340186 BRANCH=None TEST=IPU is enabled and shows in lspci.
Signed-off-by: Ravi Sarawadi ravishankar.sarawadi@intel.com Change-Id: I66d60474e16c7a9aa8006d42b22510c1495dbd84 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44628 Reviewed-by: Daniel H Kang daniel.h.kang@intel.corp-partner.google.com Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb M src/mainboard/google/volteer/variants/volteer2/overridetree.cb 2 files changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Wonkyu Kim: Looks good to me, approved Daniel H Kang: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb index b4948ec..2ef9fc9 100644 --- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb @@ -48,6 +48,7 @@ register "IomTypeCPortPadCfg[1]" = "0x090E000D"
device domain 0 on + device pci 05.0 on end # IPU 0x9A19 device pci 15.0 on chip drivers/i2c/generic register "hid" = ""10EC5682"" diff --git a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb index 3036a48..0bb82f1 100644 --- a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb @@ -6,6 +6,7 @@ register "DdiPort2Hpd" = "0"
device domain 0 on + device pci 05.0 on end # IPU 0x9A19 device pci 15.0 on chip drivers/i2c/generic register "hid" = ""10EC5682""
-
Daniel H Kang (Code Review) -
Daniel Kang (Code Review)
-
Furquan Shaikh (Code Review)
-
Ravishankar Sarawadi (Code Review)
-
Wonkyu Kim (Code Review)