Attention is currently required from: Jérémy Compostella, Paul Menzel, Pranava Y N, Subrata Banik.
Li1 Feng has posted comments on this change by Li1 Feng. ( https://review.coreboot.org/c/coreboot/+/85464?usp=email )
Change subject: mb/google/fatcat: config GPP_F23 as ISH gpio pin
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/fatcat/variants/fatcat/fw_config.c:
https://review.coreboot.org/c/coreboot/+/85464/comment/afbf5494_5500d311?usp... :
PS5, Line 461: PAD_NC(GPP_E05, NONE),
/* GPP_F23: Not used */ […]
Done
File src/mainboard/google/fatcat/variants/fatcat/gpio.c:
https://review.coreboot.org/c/coreboot/+/85464/comment/9f1cf537_b527e683?usp... :
PS5, Line 302: /* GPP_F23: Not used */
: PAD_NC(GPP_F23, NONE),
please drop
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85464?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I19a4d6967acf96aefe2f38d628f898811d8a6e6d
Gerrit-Change-Number: 85464
Gerrit-PatchSet: 6
Gerrit-Owner: Li1 Feng
li1.feng@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Wed, 11 Dec 2024 00:42:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com