Attention is currently required from: Reto Buerki.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80261?usp=email )
Change subject: mb/up/squared: Make mini PCIe port mode configurable ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80261/comment/eaf35f2f_fe09393a : PS2, Line 9: Add ENABLE_MSATA config knob and pad configuration to put Mini PCIe port : into mSATA mode. Did you test if the PCIe functionality still works? I'm wondering because you are not disabling the FSP options.
File src/mainboard/up/squared/Kconfig:
https://review.coreboot.org/c/coreboot/+/80261/comment/088954f7_94cd2ea6 : PS2, Line 77: config ENABLE_MSATA : bool "Use mini-PCIe port for mSATA" : default n I think a choice menu would be better since the distinction between both functions (SATA vs PCIe) is much more clear.