Attention is currently required from: Hope Wang, Hung-Te Lin.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85563?usp=email )
Change subject: mb/google/rauru: Implement regulator interface
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/rauru/regulator.c:
https://review.coreboot.org/c/coreboot/+/85563/comment/6c217a95_05a7b720?usp... :
PS4, Line 26: if (id < 0) {
: printk(BIOS_ERR, "Invalid regulator ID: %d\n", regulator);
: return;
: }
The logic was supposed to support the power rails from multiple PMICs. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85563?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3cad68dbb2c5873c4e00066da18b1593b88ff499
Gerrit-Change-Number: 85563
Gerrit-PatchSet: 4
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Fri, 13 Dec 2024 11:02:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: Jarried Lin
jarried.lin@mediatek.com