Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30178 )
Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/30178/2/src/mainboard/google/poppy/variants/...
File src/mainboard/google/poppy/variants/nami/mainboard.c:
https://review.coreboot.org/#/c/30178/2/src/mainboard/google/poppy/variants/...
PS2, Line 250: case SKU_0_EKKO:
: case SKU_1_EKKO:
: case SKU_2_EKKO:
: case SKU_3_EKKO:
: case SKU_0_BARD:
: case SKU_1_BARD:
: case SKU_2_BARD:
: case SKU_3_BARD:
: pl2_id = PL2_ID_BARD_EKKO;
Okay. So, the port 5 needs to be kept enabled. […]
Ok ! updated !
add "break;"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30178
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0
Gerrit-Change-Number: 30178
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 12 Dec 2018 09:15:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment