Attention is currently required from: Tim Wawrzynczak, Derek Huang, Brandon Breitenstein, Curtis Chen.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57138 )
Change subject: src/ec/google/chromeec: Add APIs for USB-C DP ALT mode
......................................................................
Patch Set 13: Code-Review+2
(1 comment)
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/57138/comment/0d999c2f_5b9a6907
PS13, Line 1675: !(mux_flags & USB_PD_MUX_HPD_LVL) || !(mux_flags & USB_PD_MUX_DP_ENABLED)
nit: This can also be written as :
```
while ((mux_flags & hpd_asserted_mask) != hpd_asserted_mask));
```
where,
```
hpd_asserted_mask = USB_PD_MUX_HPD_LVL | USB_PD_MUX_DP_ENABLED;
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57138
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id11510c1ff58579ae2cddfe5a4d69646fd84f5c3
Gerrit-Change-Number: 57138
Gerrit-PatchSet: 13
Gerrit-Owner: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Attention: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 01 Oct 2021 00:06:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment