Attention is currently required from: Joey Peng, Nick Vaccaro, YH Lin.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56802 )
Change subject: mb/google/brya/variant/taeko: Update devicetree settings
......................................................................
Patch Set 5:
(3 comments)
File src/mainboard/google/brya/variants/taeko/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56802/comment/6dcd81c0_5b74c30a
PS5, Line 67: probe AUDIO RT1011_ALC5682I_I2S
a `probe` statement can only be added when you have the `fw_config` section filled out already, for example: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
https://review.coreboot.org/c/coreboot/+/56802/comment/264f77ab_c25f36a9
PS5, Line 75: probe AUDIO RT1011_ALC5682I_I2S
same
https://review.coreboot.org/c/coreboot/+/56802/comment/3f7663e4_a26845b7
PS5, Line 83: probe AUDIO RT1011_ALC5682I_I2S
same
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56802
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96aaf48284a226edc39115f870bf0f3dd83ab8b4
Gerrit-Change-Number: 56802
Gerrit-PatchSet: 5
Gerrit-Owner: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: YH Lin
yueherngl@chromium.org
Gerrit-Comment-Date: Fri, 06 Aug 2021 17:32:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment