Change in coreboot[master]: AGESA binaryPI: Use common acpi_fill_madt() - coreboot-gerrit

15 Jul 2021


      Attention is currently required from: Michał Żygowski, Alexander Couzens, Patrick Rudolph, Piotr Król.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55569 )
Change subject: AGESA binaryPI: Use common acpi_fill_madt()
......................................................................
Patch Set 2:
(1 comment)
File src/northbridge/amd/pi/00730F01/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/55569/comment/a5d8c934_a29e752b 
PS2, Line 11: 	/* Write SB800 IOAPIC, only one */
...
nit: probably should be FCH IOAPIC. […]
This commit just moves the file to better location and no more.
Immediate follow-ups suggest to change the code below to remove MAX_CPUS reference, fix the comment there?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55569
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I01ee0ba99eca6ad4c01848ab133166f8c922684d
Gerrit-Change-Number: 55569
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Alexander Couzens lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Piotr Król piotr.krol@3mdeb.com
Gerrit-Comment-Date: Thu, 15 Jul 2021 09:43:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-MessageType: comment