Attention is currently required from: Lean Sheng Tan, Mario Scheithauer, Werner Zeh.
Felix Singer has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83294?usp=email )
Change subject: 3rdparty/fsp: Update submodule to upstream master ......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/elkhartlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/83294/comment/797f5744_38f8b8fc?usp... : PS3, Line 195: FSPRel.bin"
We just recently changed it in CB:81344. […]
Yeah, this is what they have on their [master branch](https://github.com/intel/FSP/tree/master/ElkhartLakeFspBinPkg/FspBin).
I think there is a bit chaos in the FSP repository.. Look at the [commit history](Here is the commit history for the FspBin directory. https://github.com/intel/FSP/commits/master/ElkhartLakeFspBinPkg/FspBin) for the FspBin directory.
When I updated the submodule pointer in CB:81344, which is still in use, commit [4707bc7ab7](https://github.com/intel/FSP/commit/4707bc7ab793a1c5f179743f74d739278d9c149c) gets introduced, which adds FSP.fd for a newer FSP version, but FSPRel.bin from an older version still remains. @mario.scheithauer@siemens.com pointed out that FSP.fd is the correct name.
In the follow-up commit [aada6a55e1](https://github.com/intel/FSP/commit/aada6a55e1b4c0d9eeb04b7bbe68198c3daa6ad5), which is pulled in with this change, the commit message suggests that FSPRel.bin is removed, but actually FSP.fd is removed and FSPRel.bin is updated to the version of FSP.fd.
Well, and no filename change with the most [recent commit](https://github.com/intel/FSP/commit/8134dbd3dcfadee8a75300c0a6ef2b78d7ee81a6).