Attention is currently required from: CoolStar, Felix Held, Jason Nien, Martin Roth, Matt DeVillier, Nico Huber, Paul Menzel, Raul Rangel.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75874?usp=email )
Change subject: mb/google/kahlee: Enable Secure OS
......................................................................
Patch Set 7:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75874/comment/6edaa072_8e39f32f :
PS5, Line 7: secure
Secure
Done
https://review.coreboot.org/c/coreboot/+/75874/comment/17cca391_3bf5b8f6 :
PS5, Line 10: risks
Just out of curiosity: The help text of the Kconfig doesn't mention […]
Nothing specific, just reduce attack surface, it's not used, so it was disabled
https://review.coreboot.org/c/coreboot/+/75874/comment/83f8f212_ec5f4bda :
PS5, Line 15: secure
Secure
Done
https://review.coreboot.org/c/coreboot/+/75874/comment/a6b7e472_29566766 :
PS5, Line 17:
does not resolve because updated PSP bootloader is needed
Yea, this will enable the solution but does not resolve the issue.
File src/mainboard/google/kahlee/Kconfig:
https://review.coreboot.org/c/coreboot/+/75874/comment/8f9c0317_1d1fe261 :
PS5, Line 148: # Don't use AMD's Secure OS if ChromeOS build.
Commit 09abb879a41a (mainboard/google/kahlee: Don't use AMD's secure OS, Change-Id https://review. […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75874?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I213aebc41cae300ecee8c01fc5c7687f7e7f5ee3
Gerrit-Change-Number: 75874
Gerrit-PatchSet: 7
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: CoolStar
coolstarorganization@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: CoolStar
coolstarorganization@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 28 Jun 2023 17:07:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: CoolStar
coolstarorganization@gmail.com
Gerrit-MessageType: comment