Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83684?usp=email )
Change subject: acpi/acpigen_ps2_keybd: Move KEY_DELETE to rest_of_keymaps ......................................................................
acpi/acpigen_ps2_keybd: Move KEY_DELETE to rest_of_keymaps
This patch supports keyboards that have delete key but without numpad.
To prevent KEY_DELETE be defined twice, move it from numeric_keypad_keymaps to rest_of_keymaps.
BUG=b:345231373 TEST=Build and test on Riven/Craaskino, delete key function works
Change-Id: Ib922a2b52fa7152ba3d9deb44e2c8200b2a3802c Signed-off-by: Tyler Wang tyler.wang@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83684 Reviewed-by: Dinesh Gehlot digehlot@google.com Reviewed-by: David Wu david_wu@quanta.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Subrata Banik subratabanik@google.com --- M src/acpi/acpigen_ps2_keybd.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Eric Lai: Looks good to me, but someone else must approve Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified David Wu: Looks good to me, but someone else must approve Dinesh Gehlot: Looks good to me, approved
diff --git a/src/acpi/acpigen_ps2_keybd.c b/src/acpi/acpigen_ps2_keybd.c index 43a1ece..8691207 100644 --- a/src/acpi/acpigen_ps2_keybd.c +++ b/src/acpi/acpigen_ps2_keybd.c @@ -69,7 +69,6 @@ KEYMAP(0xc7, KEY_HOME), KEYMAP(0xcf, KEY_END), /* Row-1 */ - KEYMAP(0xd3, KEY_DELETE), KEYMAP(0xb5, KEY_KPSLASH), KEYMAP(0x37, KEY_KPASTERISK), KEYMAP(0x4a, KEY_KPMINUS), @@ -99,6 +98,7 @@ static uint32_t rest_of_keymaps[] = { /* Row-0 */ KEYMAP(0x01, KEY_ESC), + KEYMAP(0xd3, KEY_DELETE), /* Row-1 */ KEYMAP(0x29, KEY_GRAVE), KEYMAP(0x02, KEY_1),